Bug 143031 - [EMF+] Brush Object with Type PathGradient is not supported
Summary: [EMF+] Brush Object with Type PathGradient is not supported
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Bartosz
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords:
Depends on:
Blocks: EMF-WMF
  Show dependency treegraph
 
Reported: 2021-06-24 03:54 UTC by Valek Filippov
Modified: 2022-06-27 14:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
EMF sample with EMF+ Brush PathGradient (2.52 KB, image/x-emf)
2021-06-24 03:55 UTC, Valek Filippov
Details
How it should look like (35.65 KB, image/png)
2021-06-24 03:56 UTC, Valek Filippov
Details
EMF+ Original file which is displayed incorrectly (158.50 KB, application/vnd.ms-powerpoint)
2022-06-12 19:55 UTC, Bartosz
Details
EMF+ file opened with MS Office (153.51 KB, image/png)
2022-06-13 08:35 UTC, Bartosz
Details
EMF+ Original file which is displayed incorrectly (528.39 KB, image/emf)
2022-06-13 08:43 UTC, Bartosz
Details
attachment 173127 file in Paint and current master (93.13 KB, image/png)
2022-06-15 13:16 UTC, Gabor Kelemen (allotropia)
Details
attachment 180719 file in Paint and current master (220.89 KB, image/png)
2022-06-15 13:19 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Valek Filippov 2021-06-24 03:54:00 UTC
Description:
LO doesn't support Brush with type PathGradient.

Steps to Reproduce:
Open attached EMF sample.

Actual Results:
LO draws empty object.

Expected Results:
It show draw square filled with circles filled with gray to yellow gradient.


Reproducible: Always


User Profile Reset: No



Additional Info:
Minified from AOO i#103355.
Comment 1 Valek Filippov 2021-06-24 03:55:19 UTC
Created attachment 173127 [details]
EMF sample with EMF+ Brush PathGradient
Comment 2 Valek Filippov 2021-06-24 03:56:43 UTC
Created attachment 173128 [details]
How it should look like
Comment 3 Roman Kuznetsov 2021-06-24 13:18:21 UTC
confirm in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: de7356c2e0cb099fac396808b5a86a0393b48e5f
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded
Comment 4 Bartosz 2022-06-12 19:55:55 UTC
Created attachment 180693 [details]
EMF+ Original file which is displayed incorrectly
Comment 5 Bartosz 2022-06-13 08:35:28 UTC
Created attachment 180718 [details]
EMF+ file opened with MS Office
Comment 6 Bartosz 2022-06-13 08:43:39 UTC
Created attachment 180719 [details]
EMF+ Original file which is displayed incorrectly
Comment 7 Commit Notification 2022-06-14 08:31:26 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b12c659842eb53b96dd98ecea65c6071506dfbb

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-06-15 04:30:03 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a1d4093bf44058c1d956717404817cb82a830521

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-06-15 06:42:19 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/8419e2909aef8916111e4dce9c0a070464a06e66

tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Gabor Kelemen (allotropia) 2022-06-15 13:16:54 UTC
Created attachment 180785 [details]
attachment 173127 [details] file in Paint and current master

First example still looks bad in:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 7efd118d5d48e1d4b2f57752cb3b9170f5c05f71
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

instead of several gradient filled circles, it has full orange fill (earlier it was entirely transparent)
Comment 11 Gabor Kelemen (allotropia) 2022-06-15 13:19:49 UTC
Created attachment 180786 [details]
attachment 180719 [details] file in Paint and current master

The second example file is still slightly bad, the gradient of the text has a much smaller radius.
Comment 12 Commit Notification 2022-06-27 08:24:52 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5b21b65572610df88986e700b81f1156aff14f65

tdf#142770 tdf#143031 EMF+ Implement CustomLineCap

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2022-06-27 14:41:21 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/ba806269c998b96842bcf0986095f22ab99a686a

tdf#142770 tdf#143031 EMF+ Implement CustomLineCap

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.