Bug 131781 - Calculating optimal width relatively slow CPU/consuming (Win-only)
Summary: Calculating optimal width relatively slow CPU/consuming (Win-only)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: Performance
  Show dependency treegraph
 
Reported: 2020-04-01 13:03 UTC by Telesto
Modified: 2022-09-10 05:18 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (2.68 MB, application/vnd.oasis.opendocument.spreadsheet)
2020-04-01 13:03 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-04-01 13:03:20 UTC
Description:
Calculating optimal width relatively slow CPU/consuming

Steps to Reproduce:
1. Open the attached file
2. Select column A
3. Expand the toolbar button column & click optimal width (takes 5-10 seconds)

Actual Results:
It takes 5- 10 seconds on a column of data

Expected Results:
It must be possible to do this bit faster


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2020-04-01 13:03:40 UTC
Created attachment 159222 [details]
Example file
Comment 2 Xisco Faulí 2020-05-13 11:45:06 UTC
takes 6 seconds for me

Version: 7.0.0.0.alpha1+
Build ID: 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

could you please add your measurements ? 5-10 seconds doesn't seems precise to me
Comment 3 Telesto 2020-05-13 19:48:01 UTC
8 Seconds with 7.0
3 seconds with 4.0.0.3
Comment 4 Buovjaga 2020-08-28 20:50:50 UTC
No repro on Linux, but yes on Windows

Bibisected with 6.3 to https://git.libreoffice.org/core/commit/b7ddc514bff9bdf682abae537f990aa01dc2c0fb
Upgrade to latest HarfBuzz 2.3.1

So the same effects as bug 131909
Comment 5 QA Administrators 2022-09-07 03:58:24 UTC Comment hidden (obsolete)
Comment 6 loic_dupont 2022-09-09 12:53:51 UTC
According to : 
https://wiki.documentfoundation.org/QA/GetInvolved

I retested it. 

It's now 3.5 seconds. Not perfect, but seems better :-/

version : 
Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 24; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL
Comment 7 Buovjaga 2022-09-09 15:37:13 UTC
I get these on Windows 10

7.0 bibisect repo, oldest: 22.7 secs (same result with 7.1 repo newest)
7.5: 3.8 secs

so it seems like quite an improvement.
Comment 8 Telesto 2022-09-09 21:29:57 UTC
seems resolved based on comment 3 + comment 6
Comment 9 Buovjaga 2022-09-10 05:18:58 UTC
Yeah, let's close. Many Calc optimisations have been made in the two years since this was reported and more will surely follow.