Description: Crash: reject/clear formatting Steps to Reproduce: 1. open the attached file 2. Edit -> Track Changes -> Manage -> Reject clear formatting Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ (x64) Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
Please attach file.
Created attachment 159345 [details] Example file
Created attachment 159347 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. I attached bt. I noticed this on console too: warn:legacy.osl:162554:162554:sc/source/ui/view/reffact.cxx:224: missing view shell :-(
I could reproduce this too on LO Debian package 6.4.2.2
Eike: I tested this straightforward patch and it worked: diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx index 0b9f18ec3779..fd720806fc2a 100644 --- a/sc/source/core/tool/chgtrack.cxx +++ b/sc/source/core/tool/chgtrack.cxx @@ -4191,8 +4191,7 @@ bool ScChangeTrack::Reject( bRejected = pAct->Reject( pDoc ); if ( bRejected ) { - // pRefDoc NULL := Do not save deleted Cells - AppendDeleteRange( pAct->GetBigRange().MakeRange(), nullptr, short(0), + AppendDeleteRange( pAct->GetBigRange().MakeRange(), pDoc, short(0), pAct->GetActionNumber() ); } } However, it does the contrary of the comment deleted: // pRefDoc NULL := Do not save deleted Cells Git history of this comment gives: commit 9964dbdda0dd8bb0471a3153ce133a76e98a09b0 Author: Philipp Weissenbacher <p.weissenbacher@gmail.com> Date: Thu Nov 14 12:46:35 2013 +0100 Translate German comments then: commit d0484bcdcbffd42d242647a2fdc1a203d176b775 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 23:16:46 2000 +0000 initial import Any thoughts here?
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0ef5c47547bec6319b853326603f3b807407fe78 author Noel Grandin <noel.grandin@collabora.co.uk> 2019-10-28 13:08:29 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2019-10-29 14:22:48 +0100 commit 0ef5c47547bec6319b853326603f3b807407fe78 (patch) tree ced33b9ae621fa1cd807f8647a5149eed8bc743b parent 07bde58988705ca45a619eb7a4e670a5d951abf6 (diff) sc: rowcol: tdf#50916 convert core/tool Bisected with: bibisect-linux64-6.4 Adding Cc: to Noel Grandin
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c076b99dd21edae0364cf9319a221a1d6a4bd487 tdf#131907 Crash: reject/clear formatting It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/f973091959dacd74501606a01099f107d25d8fc7 tdf#131907 Crash: reject/clear formatting It will be available in 6.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
UItest added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=4a581f12e0d0fa105f053904300b729acb18194a
Setting to VERIFIED since there is already a test covering it. @Noel, thanks for fixing this issue!