Description: Crash undo/redo inserting image in calc Steps to Reproduce: 1. Open Calc 2. insert the attached file (insert image button toolbar) 3. CTRL+Z 4. Insert the image again 5. CTRL+Z (3 times) 6. CTRL+Y -> Crash Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ (x64) Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL 000000ba`1293e600 00007ffc`83a56448 : 000000ba`1eb9fc50 00000000`00000000 000000ba`1293e720 00007ffc`83a51a77 : mergedlo!cppu::WeakAggImplHelper2<com::sun::star::util::XNumberFormatsSupplier,com::sun::star::lang::XUnoTunnel>::getImplementationId+0x2c4 000000ba`1293e630 00007ffc`839dd0e9 : 000000ba`1f2ae370 000000ba`1293e720 000000ba`1f2ae140 000000ba`1ec353f8 : mergedlo!SdrUndoObjSetText::GetComment+0x368 000000ba`1293e6c0 00007ffc`83a57a74 : 00007ffc`a9f0b340 000000ba`1f2ae370 00007ffc`a9f0b340 000000ba`1ebbb3e0 : mergedlo!SdrObject::SetName+0x129 000000ba`1293e710 00007ffc`83a576c9 : 000000ba`1293e970 000000ba`1ec353f8 00000000`00000002 00007ffc`83a576b0 : mergedlo!SdrUndoObjSetText::Redo+0x174 000000ba`1293e740 00007ffc`77552bc1 : 000000ba`1ed99aa0 000000ba`1ec353f8 00000000`00000002 00007ffc`77552bac : mergedlo!SdrUndoGroup::Redo+0x29 000000ba`1293e770 00007ffc`8355adc6 : 000000ba`1293e948 00000000`00000000 00007ffc`821532f0 00000000`00000000 : sclo!ScDocShell::IsPaintLocked+0x1c8d1 000000ba`1293e7a0 00007ffc`777bbda7 : 000000ba`184a5e10 000000ba`184a5e10 000000ba`1ec353a0 000000ba`184a5b40 : mergedlo!SfxUndoManager::ImplRedo+0x156 000000ba`1293e870 00007ffc`830e74dd : 000000ba`17cdd710 000000ba`1293eb00 00000000`00000000 000000ba`1293eb80 : sclo!ScTabViewShell::ExecuteUndo+0x217 000000ba`1293e900 00007ffc`830dc9ef : 000000ba`17edf660 000000ba`17edf660 00000000`00000001 000000ba`1293eb80 : mergedlo!SfxDispatcher::Call_Impl+0x27d 000000ba`1293e9b0 00007ffc`8312d54e : 00000000`00000000 00000000`00000000 00000000`00000000 000000ba`17946a10 : mergedlo!SfxBindings::Execute_Impl+0x2cf 000000ba`1293ea60 00007ffc`8312d990 : 000000ba`1293ed58 000000ba`183301a0 000000ba`1eef1c80 000000ba`1f2ae910 : mergedlo!SvxCharView::setMouseClickHdl+0x5d4e 000000ba`1293ed10 00007ffc`83621277 : 00000000`00000000 00007ffc`8312d940 000000ba`180daba8 00000000`00000000 : mergedlo!SvxCharView::setMouseClickHdl+0x6190 000000ba`1293ed40 00007ffc`841db975 : 000000ba`1ef3e800 00000000`00000010 00007ffc`b34e30a0 000000ba`1ef3e828 : mergedlo!svt::AcceleratorExecute::findCommand+0xc7 000000ba`1293ed90 00007ffc`8462da2c : 000000ba`175eea00 00000000`00000001 00000000`00000000 00000000`00000206 : mergedlo!FloatingWindow::ImplSetMouseDown+0xb15 000000ba`1293f090 00007ffc`9ecc6c95 : 00000000`00000482 00000000`00000482 00000000`00000000 00001a70`622f5cdf : mergedlo!SalFrame::CallCallback+0x1c 000000ba`1293f0c0 00007ffc`9ecc752d : 00001a70`622f5d7f 00000000`00000000 00007ffc`9ecc74e0 00000000`00000000 : vclplug_winlo!create_SalInstance+0x4b815 000000ba`1293f200 00007ffc`bdcc24fd : 00000000`0015109a 00000000`00000482 00000000`00000000 000000ba`1f238940 : vclplug_winlo!create_SalInstance+0x4c0ad 000000ba`1293f270 00007ffc`bdcc2357 : 000000ba`1327ea20 000000ba`1293f3f0 00000000`0015109a 00000000`00020000 : USER32!UserCallWinProcCheckWow+0x149 000000ba`1293f340 00007ffc`9ec782c4 : 00000000`00000001 00000000`00000001 00000000`00000000 00000000`00000206 : USER32!DispatchMessageWorker+0x1a7 000000ba`1293f3c0 00007ffc`9ec77e91 : 00007ffc`86622601 00000000`00000001 00000000`00000001 000000ba`12d33eb0 : vclplug_winlo+0x182c4 000000ba`1293f450 00007ffc`8452c934 : 000000ba`00000001 00007ffc`866226e0 00000000`0000ffff 00000000`00000000 : vclplug_winlo+0x17e91 000000ba`1293f480 00007ffc`8337d4be : 000000ba`00000000 000000ba`17bed240 00000000`00000001 000000ba`166710b0 : mergedlo!Application::Execute+0x164 000000ba`1293f4e0 00007ffc`8453b8e7 : 000000ba`176d5620 00000000`00000000 00007ff7`02096000 00000000`00000000 : mergedlo!SfxTabPage::set_visible+0x550e 000000ba`1293f720 00007ffc`8339e9c9 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : mergedlo!ImplSVMain+0x67 000000ba`1293f750 00007ff7`0263105b : 000000ba`12d28170 000000ba`12d2f460 000000ba`12d2f460 00007ff7`0263104c : mergedlo!soffice_main+0xf9 000000ba`1293f800 00007ff7`02631308 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : soffice!main+0x1b 000000ba`1293f830 00007ffc`bc4313d2 : 00007ff7`02631408 00007ff7`02096000 00000000`00000000 00000000`00000000 : soffice!main+0x2c8 000000ba`1293f870 00007ffc`bde554f4 : 00007ffc`bc4313b0 00000000`00000000 00000000`00000000 00000000`00000000 : KERNEL32!BaseThreadInitThunk+0x22 000000ba`1293f8a0 00000000`00000000 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!RtlUserThreadStart+0x34
Created attachment 159343 [details] Image
Confirmed on windows 10 x64 with Version: 6.3.5.2 (x64) Build ID: dd0751754f11728f69b42ee2af66670068624673 CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win crashreport.libreoffice.org/stats/crash_details/0a0f6728-8a6c-48f1-a1aa-c92c3d90c82b
For me it crashes at step 5 in Version: 7.0.0.0.alpha0+ Build ID: 6c7d51643634a4a4111f673760567e10e48467d0 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: ja-JP (en_US.UTF-8); UI-Language: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=dfefe448c41921f2f1e54d3f69b8b9e89031d055 author Armin Le Grand <Armin.Le.Grand@cib.de (CIB)> 2018-03-01 15:54:32 +0100 committer Armin Le Grand <Armin.Le.Grand@cib.de> 2018-04-07 00:28:30 +0200 commit dfefe448c41921f2f1e54d3f69b8b9e89031d055 (patch) tree 1aace31054b5740e2faffcbc5de66a791be27f7d parent eba4d5b2b76cefde90cb3d6638c736f435023a45 (diff) SOSAW080: Added first bunch of basic changes to helpers Bisected with: bibisect-linux64-6.1 Adding Cc: to Armin Le Grand
reproduced on: Version: 6.4.3.2 (x64) Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded Crash report: https://crashreport.libreoffice.org/stats/crash_details/dec9cc9b-1986-423a-91ab-a70d64da4edd
Repro. Retested in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
Can't reproduce in LO 7.4.1.2. Described steps works fine.
Issue fixed by author Noel Grandin <noel.grandin@collabora.co.uk> 2021-05-27 10:27:46 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2022-08-29 13:44:02 +0200 commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3 (patch) tree fa2b0e463aafb51df754768f916ca9104969a557 parent 25a997c15d39fb30676a375df8ea4ce1ed2e1acd (diff) ref-count SdrObject Closing as RESOLVED FIXED