Bug 132146 - Using RTL language when tracking changes but not showing them can break spacebar behaviour
Summary: Using RTL language when tracking changes but not showing them can break space...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.2.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: text:rtl
Depends on:
Blocks: Track-Changes Hebrew
  Show dependency treegraph
 
Reported: 2020-04-16 12:05 UTC by Yotam Benshalom
Modified: 2021-02-12 14:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yotam Benshalom 2020-04-16 12:05:24 UTC
When typing in RTL language when tracking changes is ON but showing changes is OFF, sometimes pressing the spacebar adds the space charachter but fails to advance the carret foreward. This means that instead of
זה משפט בעברית
I get
זהמשפטבעברית
followed by two spaces.

This does not happen always, but it is really annoying when it does. It happens in long documents with many tracked changes more often than in small ones, but it can happen anywhere.

A workaround for this is. typing. really. really. slowly.

I use ubuntu 20.04.
Comment 1 Xisco Faulí 2020-05-11 11:35:12 UTC
Thanks for reporting this issue.
So, which are the steps?
1. Open writer
2. Enable tracking changes
3. Type זה משפט בעברית
4. Disable tracking changes? accept changes ?
Comment 2 Yotam Benshalom 2020-05-11 11:47:34 UTC
1. Open a long document with many unaccepted changes (to maximise the chances of reproduction).
2. Make sure that tracking changes is ENABLED, but viewing changes is DISABLED.
3. Type any Hebrew sentence quickly.

On many occassions, you should find out that the spaces were not registered in time and are added at the end of the sentence.
Comment 3 QA Administrators 2020-05-12 03:52:49 UTC Comment hidden (obsolete)
Comment 4 Buovjaga 2020-08-29 20:39:09 UTC
Yotam: now that you know how to bibisect, maybe you could investigate, if this is a regression. You can quickly test with a selection of older versions by using appimages: https://libreoffice.soluzioniopen.com/

There have certainly been big internal renovations to change tracking code in the recent years.
Comment 5 Eyal Rozenberg 2021-02-11 23:17:03 UTC
(In reply to Yotam Benshalom from comment #2)
> 1. Open a long document with many unaccepted changes (to maximise the
> chances of reproduction).

Would you be willing to attach such a document, and given more exact reproduction instruction instructions based on it?
Comment 6 Yotam Benshalom 2021-02-11 23:29:20 UTC
This is a client's document - not exactly confidential, but not one I want on google results either. I'll mail it to you.
Comment 7 Eyal Rozenberg 2021-02-12 13:23:05 UTC
(In reply to Yotam Benshalom from comment #6)
> This is a client's document - not exactly confidential, but not one I want
> on google results either. I'll mail it to you.

I got the file from Yotam and checked with:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Linux 5.9; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

and could not reproduce the bug. Yotam wrote me:

> I couldn't repro it now, but it gave me trouble earlier, and I use 
> ubuntu 21.04 now - maybe this is related.

At the moment no one is know to be able to reproduce this issue, so I am closing it as WORKSFORME. Yotam, if you do see this again, please reopen.