Created attachment 159917 [details]
Screenshot

Issue is follow-up from tdf#125510.

(In reply to Thorsten Wagner from comment #0)
> Description:
> Icon "Display Views" missing within Impress' toolbar (see screenshot) while
> using Colibre icon set.
> 

The icons are available so they are not missing


> Steps to Reproduce:
> (1) Open Impress
> 
> Actual Results:
> Icon "Display Views" is missing and replaced by an icon from another icon
> set.


Icon "Display View" and all icons in the drop down are already use Colibre version and *I repeat it* they are not missing.


> Furthermore replacement icon is too large and causes selection
> rectangle to be cropped on top and bottom.

I thought you requested to change the icons to have larger size (see tdf#125510) but seems you request here is to make it smaller? .

I do not know icon geometry exactly, but current icon geometry causes cropping selection rectangle on top and button when moving mouse over. This is visible on Linux and macOS at least.

Maybe it is a solution to use a larger icon which is rendered within toolbar icon bounds correctly caused by some kind of scaling. Other icons within toolbar currently look smaller. From a UI design perspective I think icons with equal size have to be preferred.

Attached two additional screenshots taken with mouse over:

Screenshot 2: Icon with cropped selection rectangle on top and bottom when moving mouse over

Screenshot 3: Another icon with correctly rendered selection rectangle when moving mouse over

Issue has something to do with icon size. Change for tdf#125510 caused selection rectangle to be rendered completely.

Created attachment 159923 [details]
Screenshot 2

Created attachment 159924 [details]
Screenshot 3

*** Bug 132402 has been marked as a duplicate of this bug. ***

This bug related to code, not to specific icon theme as I stated in https://bugs.documentfoundation.org/show_bug.cgi?id=132402#c3

I agree with this request, we need to make "dynamic" Display Views icon use valid size. We need the code to point out the icon to several icons that are already available in all of icon theme. So this list contain every candidate of the icon theme name corresponding with the .uno"command that should be used if someone interests to provide the code

Edit Modes

1. Normal: .uno:NormalMultiPaneGUI
2. Outline: .uno:OutLineMode
3. Notes: .uno:NotesMode
4. Slide Sorter: .uno:DiaMode

Master Modes

1. Master Slides: .uno:SlideMasterPage
2. Master Notes: .uno:NotesMasterPage
3. Master Handout: .uno:HandoutMode

if it is a problem within code, I am wondering why a similar issue does not exist for other icons, e.g. Slide Layout icon within same toolbar. Slide Layout icon has a dropdown too and is displayed correctly.

BTW: dropdown arrow on the right of Display Views icon is larger than other dropdown arrows within same toolbar too.

What is the difference?

Confirming that issue seems to exist for icon size "large" only, not for icon sizes "small" and "extra large".

(In reply to Thorsten Wagner from comment #9)
> if it is a problem within code, I am wondering why a similar issue does not
> exist for other icons, e.g. Slide Layout icon within same toolbar. Slide
> Layout icon has a dropdown too and is displayed correctly.
> 

Simply because Slide Layout icon is just a static icon, it does not change based on the icon within the drop down box. 

> BTW: dropdown arrow on the right of Display Views icon is larger than other
> dropdown arrows within same toolbar too.
> 
> What is the difference?

Simply put, I don't really know the answer. I have similar issue with the triangle arrow in RTL UI: it get lost (and I remember still have not file a bug)
> 
> Confirming that issue seems to exist for icon size "large" only, not for
> icon sizes "small" and "extra large".

Are you sure? Try switch the mode e.g. from Normal to Master Slide after changing icon size.

Indeed, there are further strange effects when switching between "Edit Modes" and "Master Modes". After switching to "small" and than to "extra large", icon for "small" remains. Furthermore for "large" another icon with correct size is shown until switching again to "Master Modes".

Created attachment 159975 [details]
Blurred small Display Views icon

with small size, the icons looks tiny and blurred. Pretty sure the icon is scaled down version of 32px*32px size

(In reply to Thorsten Wagner from comment #11)
> Indeed, there are further strange effects when switching between "Edit
> Modes" and "Master Modes". After switching to "small" and than to "extra
> large", icon for "small" remains. Furthermore for "large" another icon with
> correct size is shown until switching again to "Master Modes".

The main rules is here:
Every time we switch the icon size or change the icon theme, the "static" Display Views icon appears and every time we change the mode, the "dynamic" version will come.


Yes, the dynamic version has such strange unpredictable size in this case.

(In reply to Thorsten Wagner from comment #9)
> BTW: dropdown arrow on the right of Display Views icon is larger than other
> dropdown arrows within same toolbar too.
> 
> What is the difference?
> 

Ah I've found that the drop down arrow size change based on icon size. There's only two size in this case: normal and larger. In large size icon choice, whenever we switch the mode, the dropdown arrow/triangle down became larger as the "dynamic" icon version then turn to have 32px*32px size.

Guess we don't need input from UX since Rizal takes care (and Andreas might too). Removing the keyword.

(In reply to Heiko Tietze from comment #15)
> Guess we don't need input from UX since Rizal takes care (and Andreas might
> too). Removing the keyword.

We just need a code for this issue. No designer can solve.

Issue still exists for Colibre and for Sukapura, for the rest issue seems to be fixed.

Doublecheck has been taken place with current revision from master.