Bug 132696 - FILEOPEN PPTX: some rectangular shapes are missing (SmartArt)
Summary: FILEOPEN PPTX: some rectangular shapes are missing (SmartArt)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:7.3.0 target:7.2.1 target:7.1.6
Keywords: bibisected, bisected, regression
: 130323 141188 (view as bug list)
Depends on:
Blocks: OOXML-SmartArt
  Show dependency treegraph
 
Reported: 2020-05-04 22:52 UTC by Gerald Pfeifer
Modified: 2021-09-14 11:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample slide (PPTX) (52.90 KB, application/vnd.ms-powerpoint)
2020-05-04 22:52 UTC, Gerald Pfeifer
Details
How it looks in Office 365 (22.31 KB, image/png)
2020-05-04 22:53 UTC, Gerald Pfeifer
Details
How it looks in LibreOffice (rectangular elements missing) (15.33 KB, image/png)
2020-05-04 22:54 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2020-05-04 22:52:54 UTC
Created attachment 160363 [details]
Sample slide (PPTX)

Even though the attached document was saved from current Office 365 and
LibreOffice does not issue the usual warning about SmartArt, there is a
number of elements - rectangular shapes - that are missing in Libreoffice.
Comment 1 Gerald Pfeifer 2020-05-04 22:53:46 UTC
Created attachment 160364 [details]
How it looks in Office 365
Comment 2 Gerald Pfeifer 2020-05-04 22:54:21 UTC
Created attachment 160365 [details]
How it looks in LibreOffice (rectangular elements missing)
Comment 3 Aron Budea 2020-05-05 02:06:03 UTC
Confirmed using LO 7.0.0.0.alpha0+ (4ba1909f12b49f020195b5e767045340717ce6df), 6.3.0.4 / Ubuntu.
Rectangles appear fine in 6.2.0.3.
=> regression

Bibisected to the 6.2 backport of the following commit.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e9986153e44d7ec6ca9c5f1373971de74dcbacda
author		Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>	2019-03-14 08:25:12 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	2019-03-14 14:04:02 +0100

"PPTX import: import SmartArt drawing into single GroupShape

before that there were imported two GroupShapes:
	- empty one with properties like id, name, InteropGrapBag
	- second one with actual shapes"
Comment 4 Miklos Vajna 2021-08-05 12:49:17 UTC
The slide has a group shape, and one child of the groupshape is the smartart. The two visible shapes are imported, but not the smartart.

When manually ungrouping the shapes, the smartart shows up (not perfectly, but it's there).

Similarly, if I create a simple smartart in PowerPoint in a new document, put a triangle next to it and group them together, I hit the same problem, so that seems to be the relevant aspect of the bugdoc.

I'll take a look.
Comment 5 Commit Notification 2021-08-06 15:48:00 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/030cdbc7f8782eb196f09661bc2f116d790de9be

tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shape

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Miklos Vajna 2021-08-09 05:44:14 UTC
I think this is now fixed on master.
Comment 7 Miklos Vajna 2021-08-09 07:25:36 UTC
*** Bug 141188 has been marked as a duplicate of this bug. ***
Comment 8 Xisco Faulí 2021-08-09 15:04:01 UTC
Verified in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 6e53e03f752c2f85283c4d47efaaf0683299783c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Miklos, thanks for fixing this issue. Should it be closed as RESOLVED FIXED now ?
Comment 9 Gerald Pfeifer 2021-08-09 15:18:55 UTC
Also verifying this as the original reporter:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ac0db5736a53a4887cebbacc59026cecb7c44c66
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-08_02:51:24


Thank you, Miklos!
Comment 10 Commit Notification 2021-08-09 15:59:43 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/84033de1bfe3e6951a1f563d85e40fb6d29ff3be

tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shape

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-08-09 18:28:38 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/42132ec0c47b8439425fe8ad9925af097719a395

tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shape

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Mehmet gelisin 2021-09-11 13:04:23 UTC Comment hidden (spam)
Comment 13 Timur 2021-09-14 11:30:39 UTC
*** Bug 130323 has been marked as a duplicate of this bug. ***