Bug 132997 - "Enable char unit" bound to Asian language
Summary: "Enable char unit" bound to Asian language
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Options-Dialog
  Show dependency treegraph
 
Reported: 2020-05-13 09:16 UTC by Heiko Tietze
Modified: 2022-11-15 12:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2020-05-13 09:16:47 UTC
With latest master, the default configuration enables "char unit", which results in an uncommon measurement on indentation, for example. Even more unexpected is the fact that this option is linked with language settings and "Enable Char Unit" becomes hidden if Asian is unchecked. (Sidenote: Hiding options leads very often to usability issues.)

1) Clean the user profile
2) Check Tools > Options > Writer > General: [x] Enable Char Unit
3) Disable at Tools > Options > Language Settings > Language: [ ] Asian
4) Close the options dialog and reopen
repeat step 2 and find the option hidden

Makes not much sense to me to hide character measurement. But the default is a usability blocker since Benjamin users won't find the right checkbox. Would just disable Asian and CTL, but not sure if those are build with the average configuration.

Mine is 
--without-doxygen
--without-java
--without-help
--enable-dbgutil
--without-myspell-dicts

Version: 7.0.0.0.alpha1+
Build ID: 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c
CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: gtk3; 
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Dieter 2020-05-19 17:02:52 UTC
I confirm it with

Version: 7.0.0.0.alpha1+ (x64)
Build ID: 4804d969bacd25ad586b3bf70d3dc8c27adb48ef
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: en-GB (de_DE); UI: en-GB
Calc: threaded
Comment 2 Kevin Suo 2022-11-15 09:36:48 UTC
That control is hide (in case Asian language is disabled) at line:
https://opengrok.libreoffice.org/xref/core/sw/source/ui/config/optload.cxx?r=dd4d55b4#128

So, to resolve the issue you have requested, you can simply remove that line. However, I doubt whether it is correct to remove that line (i.e. to allow the user to enable or disable the character unit feature), as that feature was only used for Asian languages (e.g. setting the first line indent or before-text indent to be n-characters).

Also on current master, when you enable the character unit, then disable the Asian language, although the "enable character unit" control is hidden, there is no risk as the format > paragraph > indent and spacing dialog does not use "ch" units at this point.
Comment 3 Heiko Tietze 2022-11-15 12:05:11 UTC
(In reply to Kevin Suo from comment #2)
> However, I doubt whether it is correct to remove that line (i.e. to
> allow the user to enable or disable the character unit feature), as that
> feature was only used for Asian languages (e.g. setting the first line
> indent or before-text indent to be n-characters).

Don't remember at what ticket this issue was raised. But your explanation makes sense => NAB