Open ODT attachment 152744 [details] from bug 126368 and print. 2 images on 2nd page have black background (seen in PDF with virtual printer). Repro in Windows with Skia as in PDF attachment 161062 [details] and no Skia as in PDF attachment 161063 [details]. LO 7.0+ and no LO 6.4. Regression. No repro Linux and no repro PDF export. Image on 1st page is Skia only problem bug 133215.
Hi Timur, Skia related ?
(In reply to Xisco Faulí from comment #1) > Hi Timur, > Skia related ? No, I wrote "repro with Skia and no Skia", so not clear why you ask that.
(In reply to Xisco Faulí from comment #1) > Hi Timur, > Skia related ? Yesterday I wrote "repro with Skia and no Skia", so no. But with today's build and change in bug 133215, both with and without Skia prints are empty.
I confirm it with Version: 7.0.0.0.alpha1+ (x64) Build ID: 0e5e935deb0527c64865cfcc53a0421e56b74b6f CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Pages are empty in a PDF
Separate from the current empty issue, bibisect for black issue would be helpful.
Sounds a lot like: Bug 129085
(In reply to Telesto from comment #6) > Sounds a lot like: Bug 129085 But Timur says it is fine in 6.4.
Please test and bibisect. These are not JPG but objects.
Bibisected with win 6.5 repo to https://git.libreoffice.org/core/+/34a699f1894f30f68c3243784586617e01e60ab6%5E!/ vcl: refactor by creating GetActionAfterBackgroundAction() function Adding Cc: to Chris Sherlock I double-checked by flipping between the first bad & preceding commit. Tested using MS print to PDF.
(In reply to Timur from comment #0) > Open ODT attachment 152744 [details] from bug 126368 and print. > 2 images on 2nd page have black background This is https://git.libreoffice.org/core/+/6fa6704a7e7c6970b7a7c695a4a548f8dc693d03%5E!/ vcl: move functionality out of checkRect(), rendering function obsolete
Looking at this now.
I've backed out a number of changes, can you please test out https://gerrit.libreoffice.org/c/core/+/94804 ?
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/067342f063fa3ea6773297eea89e45cabbf04a56 tdf#133216 - Objects are not printed (Win-only) It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Timur from comment #3) > But with today's build and change in bug 133215, both with and without Skia > prints are empty. The empty prints started with the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=34a699f1894f30f68c3243784586617e01e60ab6 author Chris Sherlock <chris.sherlock79@gmail.com> 2020-05-12 22:35:59 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2020-05-20 10:54:47 +0200 vcl: refactor by creating GetActionAfterBackgroundAction() function
(In reply to Aron Budea from comment #14) > (In reply to Timur from comment #3) > > But with today's build and change in bug 133215, both with and without Skia > > prints are empty. > The empty prints started with the following commit: > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=34a699f1894f30f68c3243784586617e01e60ab6 > author Chris Sherlock <chris.sherlock79@gmail.com> 2020-05-12 22:35:59 +1000 > committer Tomaž Vajngerl <quikee@gmail.com> 2020-05-20 10:54:47 +0200 > > vcl: refactor by creating GetActionAfterBackgroundAction() function Chris, the problem with this commit is in the following line: https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/print2.cxx?r=34a699f1#714 MetaAction* pCurrAct <= when passing a pointer like this, you don't get back the changed pointer, and the 'for' loop after this relies on the processed pCurrAct.
Since the commits were reverted, let's call it fixed
Verified with Version: 7.1.0.0.alpha0+ (x64) Build ID: 33a720ab802491f15b247e09755cd36205b6f435 CPU-Threads: 4; BS: Windows 10.0 Build 19041; UI-Render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded