Bug 133697 - Checkboxes on main menu not drawn according system default
Summary: Checkboxes on main menu not drawn according system default
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All Windows (All)
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.4.0
Keywords:
: 100853 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-05 09:13 UTC by andreas_k
Modified: 2022-01-05 10:49 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Menubar Checkboxes (136.33 KB, image/png)
2020-06-05 09:13 UTC, andreas_k
Details
Menubar Checkboxes with 100 % screen scaling (60.24 KB, image/png)
2020-06-09 09:21 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-06-05 09:13:49 UTC
Created attachment 161645 [details]
Menubar Checkboxes

The menubar checkboxes in Windows didn't look well.

Option 1: use icons to that instead of the checkbox the icon will be shown on windows

Option 2: make the checkboxes working on windows well.
Comment 1 Heiko Tietze 2020-06-08 09:22:01 UTC
I wonder if we can deal with the issue at all. 

MikeK on IRC requests additional information: Which OS specifically (7/8/8.1/10)? which render (default/GL/Skia)? which screen scaling (100/125/150...)?
Comment 2 Noel Grandin 2020-06-08 11:01:23 UTC
Most of this stuff is drawn in 

   vcl/win/gdi/salnativewidgets-luna.cxx

and that "icon" looks a lot like a scaled up version of the regular tick we used when drawing tickboxes.

Search for MenuItemCheckMark.

I am somewhat surprised that we are not drawing the regular box that normal checkboxes use.
Comment 3 andreas_k 2020-06-08 21:22:27 UTC
Win 10 default schreen renderer and 125 screen scaling.
Comment 4 Heiko Tietze 2020-06-09 09:07:03 UTC
(In reply to andreas_k from comment #3)
> ...125 screen scaling.

Does scaling affects the checkboxes? I mean are 100% or 150% different to what you get?
Comment 5 andreas_k 2020-06-09 09:21:43 UTC
Created attachment 161791 [details]
Menubar Checkboxes with 100 % screen scaling

No difference with 100 % screen scaling. I think it's an windows problem with the checkbox symbol and can be fixed with use instead of this symbol something else from the windows backend.
Comment 6 Mike Kaganski 2021-12-29 20:31:54 UTC
It definitely depends on scaling; and it affects both default UI renderer, and Skia.

Tested with Version: 7.3.0.1 (x64) / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

and with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c02dc02a98ff58e88cf0d6f805fcb5c2b7fb1cc7
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL
Comment 7 Mike Kaganski 2021-12-30 11:36:06 UTC
https://gerrit.libreoffice.org/c/core/+/127741
Comment 8 Commit Notification 2021-12-30 17:34:31 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/089e0cb2cce6ee6f80ed1b77e333e83234fd3961

tdf#133697: use true bullet size to avoid stretching in scaled UI

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Roman Kuznetsov 2022-01-05 10:49:28 UTC
*** Bug 100853 has been marked as a duplicate of this bug. ***