Created attachment 161804 [details] Gen vs GTK3 This is a follow up of bug 133582 based on bug 133582 comment 28 The problem is that in gen the tristate checkboxes use the same icon with different background for inderminate state and true state. That's not happening with GTK3. See screncast How to reproduce it: 1. Open attachment 151163 [details] from bug 125106 2. Select all 3. Format - Cell 4. Protected cell
Hope it's a matter of icon and not code.
(In reply to Caolán McNamara from https://bugs.documentfoundation.org/show_bug.cgi?id=133582#c32) > ah, I'm wrong for the gen case. It was a grayed out check-mark for the inconsistent state so had the same check shape for inconsistent vs true. That's what I guessed since I use the icon from old Galaxy era. Could you please tell me which icon(s) for tristate checkboxes? In vcl/res we have plenty icons check1.png to check9.png. I am sure it is not check1.png nor check2.png, likely chek7.png
Created attachment 161806 [details] New tristate checkbox Is this OK?
(In reply to Rizal Muttaqin from comment #3) > Created attachment 161806 [details] > New tristate checkbox > > Is this OK? I will make - darker
looks good to me
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7f6d7a0eb624d67421cd5af6462ee2a662fdff3a tdf#133819 support for tristate checkboxes It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/ab128b9d6909fe7799aec3ef34661f8ff0d6a442 tdf#133819 support for tristate checkboxes It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
it looks great in Version: 7.1.0.0.alpha0+ Build ID: d2205a26b96ed321c869f6eb7c955648c83dd805 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Rizal, thanks for fixing this issue so fast!!
(In reply to Xisco Faulí from comment #8) > it looks great in > > Version: 7.1.0.0.alpha0+ > Build ID: d2205a26b96ed321c869f6eb7c955648c83dd805 > CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11 > Locale: en-US (en_US.UTF-8); UI: en-US > Calc: threaded > > @Rizal, thanks for fixing this issue so fast!! I am more than grateful.