Bug 133819 - UI: GEN: Use another icon for tristate checkboxes
Summary: UI: GEN: Use another icon for tristate checkboxes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium enhancement
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2020-06-09 11:16 UTC by Xisco Faulí
Modified: 2020-06-10 08:56 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Gen vs GTK3 (552.41 KB, video/x-matroska)
2020-06-09 11:16 UTC, Xisco Faulí
Details
New tristate checkbox (65.85 KB, video/mp4)
2020-06-09 12:03 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-06-09 11:16:15 UTC
Created attachment 161804 [details]
Gen vs GTK3

This is a follow up of bug 133582 based on bug 133582 comment 28

The problem is that in gen the tristate checkboxes use the same icon with different background for inderminate state and true state. That's not happening with GTK3. See screncast

How to reproduce it:
1. Open attachment 151163 [details] from bug 125106
2. Select all
3. Format - Cell
4. Protected cell
Comment 1 Heiko Tietze 2020-06-09 11:26:06 UTC
Hope it's a matter of icon and not code.
Comment 2 Rizal Muttaqin 2020-06-09 12:01:59 UTC
(In reply to Caolán McNamara from https://bugs.documentfoundation.org/show_bug.cgi?id=133582#c32)
> ah, I'm wrong for the gen case. It was a grayed out check-mark for the inconsistent state so had the same check shape for inconsistent vs true.

That's what I guessed since I use the icon from old Galaxy era. Could you please tell me which icon(s) for tristate checkboxes?

In vcl/res we have plenty icons check1.png to check9.png. I am sure it is not check1.png nor check2.png, likely chek7.png
Comment 3 Rizal Muttaqin 2020-06-09 12:03:18 UTC
Created attachment 161806 [details]
New tristate checkbox

Is this OK?
Comment 4 Rizal Muttaqin 2020-06-09 12:22:11 UTC
(In reply to Rizal Muttaqin from comment #3)
> Created attachment 161806 [details]
> New tristate checkbox
> 
> Is this OK?

I will make - darker
Comment 5 Caolán McNamara 2020-06-09 13:03:46 UTC
looks good to me
Comment 6 Commit Notification 2020-06-10 00:10:59 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7f6d7a0eb624d67421cd5af6462ee2a662fdff3a

tdf#133819 support for tristate checkboxes

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-06-10 05:05:47 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ab128b9d6909fe7799aec3ef34661f8ff0d6a442

tdf#133819 support for tristate checkboxes

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2020-06-10 08:51:09 UTC
it looks great in

Version: 7.1.0.0.alpha0+
Build ID: d2205a26b96ed321c869f6eb7c955648c83dd805
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Rizal, thanks for fixing this issue so fast!!
Comment 9 Rizal Muttaqin 2020-06-10 08:56:20 UTC
(In reply to Xisco Faulí from comment #8)
> it looks great in
> 
> Version: 7.1.0.0.alpha0+
> Build ID: d2205a26b96ed321c869f6eb7c955648c83dd805
> CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded
> 
> @Rizal, thanks for fixing this issue so fast!!

I am more than grateful.