Bug 134227 - CRASH: cutting shapes
Summary: CRASH: cutting shapes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: high major
Assignee: Vasily Melenchuk (CIB)
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-06-22 09:17 UTC by Xisco Faulí
Modified: 2020-09-22 11:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-06-22 09:17:53 UTC
Steps to reproduce:
1. Open attachment 74505 [details] from bug 60558
2. Use Ctrl + A 2 times
3. Cut

-> Crash

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 94eb4f9b19b13f3548a232ec0a1f4b50bcb55d94
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-06-22 09:19:04 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b0de876bad66c84a8dd0d8d19944109e59cf21a

author	Vasily Melenchuk <vasily.melenchuk@cib.de>	2020-05-05 15:47:44 +0300
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2020-05-11 10:52:13 +0200
commit 0b0de876bad66c84a8dd0d8d19944109e59cf21a (patch)
tree 47fd990baf8cdea19e44a604d824ac819a9ce422
parent ea414f8f255d75e3be71c0d65731ff3f42f589ed (diff)
sw: set unique name for shape format even if shape name is empty

Bisected with: bibisect-linux64-7.0

Adding Cc: to Vasily Melenchuk
Comment 2 Vasily Melenchuk (CIB) 2020-07-15 08:10:11 UTC
Not reproduced with:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f2a70250459537740b3dd583e22a959d601203f
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (C); UI: en-US
Calc: threaded

@Xisco, strange. I was not able to reproduce this issue. But I hope that tdf#133437 also resolves this problem. Could you check that?
Comment 3 Xisco Faulí 2020-07-15 17:03:19 UTC
(In reply to Vasily Melenchuk (CIB) from comment #2)
> Not reproduced with:
> 
> Version: 7.1.0.0.alpha0+ (x64)
> Build ID: 7f2a70250459537740b3dd583e22a959d601203f
> CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (C); UI: en-US
> Calc: threaded
> 
> @Xisco, strange. I was not able to reproduce this issue. But I hope that
> tdf#133437 also resolves this problem. Could you check that?

Still reproducible in

Version: 7.1.0.0.alpha0+
Build ID: d851a02df57ab378ed0cc6d9362516de09c3279c
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

The hash id of your build < https://cgit.freedesktop.org/libreoffice/core/commit/?id=7f2a70250459537740b3dd583e22a959d601203f > doesn't exists... do you have some local commits not pushed to master ?
Comment 4 Vasily Melenchuk (CIB) 2020-07-15 17:10:36 UTC
(In reply to Xisco Faulí from comment #3)
> Still reproducible in
> 
> Version: 7.1.0.0.alpha0+
> Build ID: d851a02df57ab378ed0cc6d9362516de09c3279c
> CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded

Thanks for rechecking this issue! I'll check the things on Linux.


> The hash id of your build <
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=7f2a70250459537740b3dd583e22a959d601203f > doesn't exists... do you have
> some local commits not pushed to master ?
Ooops. Yes, some local changes ahead of master, but unrelated.
Comment 5 Thorsten Behrens (allotropia) 2020-07-23 11:46:43 UTC
No good ideas how to move that forward currently - problem is, document is already corrupted. Better plan would be fixing original bug 60558
Comment 6 Vasily Melenchuk (CIB) 2020-09-22 08:12:44 UTC
No longer reproducible with master.
Seems resolved by the way during fixing of another regression.
Comment 7 Xisco Faulí 2020-09-22 08:20:45 UTC
Issue fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=07a695ec1988ee8b02256cab2e07a1b429ead24b

@Vasily, thanks for fixing this issue!!
Comment 8 Commit Notification 2020-09-22 11:15:18 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4bc8c14c34232bb31edf0cb67c971f2d40dd7fdd

tdf#134227: sw_uiwriter: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.