Bug 134638 - No undo in Find&Replace dialog
Summary: No undo in Find&Replace dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 147783 (view as bug list)
Depends on: 147151
Blocks: Undo-Redo Find&Replace-Dialog Gtk4
  Show dependency treegraph
 
Reported: 2020-07-08 08:08 UTC by Aron Budea
Modified: 2023-01-09 10:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
demo of built in undo/redo in gtk4 (34.00 KB, video/webm)
2023-01-09 09:46 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2020-07-08 08:08:25 UTC
Open Writer, then Find&Replace, enter a character, and press Ctrl-Z.

=> Nothing happens. The entered character should be cleared.

This is a regression that started from the following commit, bibisected using repo bibisect-linux-64-6.3. Adding CC: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f920e86fbf3968104e1dfc0e9934e80652ed0837
author		Caolán McNamara <caolanm@redhat.com>	2019-03-22 15:59:00 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2019-03-24 18:19:29 +0100

weld SvxSearchDialog
Comment 1 Caolán McNamara 2020-07-08 09:25:55 UTC
Under non-gtk3 this works as always. GtkEntry doesn't (in gtk3) have a undo feature: https://gitlab.gnome.org/GNOME/gtk/-/issues/1690 though gtk4 apparently will
Comment 2 Eyal Rozenberg 2022-09-19 07:21:39 UTC
Added a link to the same request for the Hyperlink dialog - where I've also speculated it's a GTK issue.

Now, GTK4 is released, so - what's the plan?
Comment 3 Caolán McNamara 2022-09-19 07:55:37 UTC
what's the plan?, well you can try the current gtk4 if you want, it is a work in progress so a lot doesn't work yet.
Comment 4 Caolán McNamara 2023-01-09 09:46:59 UTC
Created attachment 184538 [details]
demo of built in undo/redo in gtk4
Comment 5 Caolán McNamara 2023-01-09 09:48:02 UTC
*** Bug 147783 has been marked as a duplicate of this bug. ***
Comment 6 Eyal Rozenberg 2023-01-09 10:05:35 UTC
So, The state of GTK bug 1690 is WONTFIX, with the solution being: Switch to GTK4. So as far as GNOME is concerned, that's the solution.

Now, Caolan writes that switches to GTK4 is a work in progress - which is obviously a legitimate state of affairs; but it is our (= LO project's) work to undertake.

IIANM, the GTK4 port is tracked in bug 147151. So, it seems like this would be resolved when that's done.

Consequently, I believe the correct state of this bug is open and being dependent on 147151.
Comment 7 Caolán McNamara 2023-01-09 10:37:19 UTC
as seen in the little video above this works right now in the gtk4 port so there isn't anything additional in the gtk4 port needed for this particular issue