When I'm making changes to fields in the Hyperlink dialog box - I can't Undo or Redo (with Ctrl+Z and Ctrl+Y on my Linux desktop). I _should_ be able to undo and redo typing, like in any textbox anywhere else. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: fb9270b238cba4f36e595c5d7f4d85f6f3f18e1c CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US
(In reply to Eyal Rozenberg from comment #0) > When I'm making changes to fields in the Hyperlink dialog box - I can't Undo > or Redo (with Ctrl+Z and Ctrl+Y on my Linux desktop). I _should_ be able to > undo and redo typing, like in any textbox anywhere else. I just tried with the search & replace dialog and the behaviour is the same. Could you please explain where that behaviour can be used ?
(In reply to Xisco Faulí from comment #1) > (In reply to Eyal Rozenberg from comment #0) > > When I'm making changes to fields in the Hyperlink dialog box - I can't Undo > > or Redo (with Ctrl+Z and Ctrl+Y on my Linux desktop). I _should_ be able to > > undo and redo typing, like in any textbox anywhere else. > > I just tried with the search & replace dialog and the behaviour is the same. > Could you please explain where that behaviour can be used ? Hmm... not sure. I would definitely want to be able to Undo in the search and replace dialogs; I guess I've just been more precise with that, while with URLs I've gotten into situations where I delete one part and not another and then change my mind. Anyway, I'm not sure where there _shouldn'_t be Undo and Redo - in textboxes. But note that I don't mean LO's Undo and Redo for the document itself - it's something separate. I guess per-appearance-of-textbox.
I think other sofwares behave the same way... Anyway, adding the UX team
(In reply to Xisco Faulí from comment #3) > I think other sofwares behave the same way... Anyway, adding the UX team Some do, some don't: * Open Firefox or Chrome, type in a URL in the URL bar, select some of it, delete and press undo - the undo works. Ditto for the Search box in Firefox. * GEdit's search pop-up and and Find-and-Replace dialog don't have Undo. Same goes for Mousepad, AbiWord, Cinnamon's Run Command dialog, and Eclipse's Search and Replace dialogs. * KWrite, Kate have Undo in its Find (& Replace) bar * CLion's Find (& Replace) bar has Undo So, it looks like the commonality might be GTK. I dislike GNOME and mostly-dislike GTK.
The RichTextBox has inbuilt redo() and undo() methods, at least. But I don't know any standard under Linux. IMO the function is not worth much effort since Undo/Redo are common and very handy for complex input but quite pointless for single click controls or text input for just one word. https://docs.microsoft.com/en-us/dotnet/api/system.windows.forms.richtextbox.redo?view=windowsdesktop-6.0
Dear Eyal Rozenberg, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping
Bug still manifests with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 6c81a09e3ef239a2d7a991d00fe3620a67298b99 CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US
Xisco, I think I've answered your NEEDINFO...
[Automated Action] NeedInfo-To-Unconfirmed
In addition to my comment 5 (not worth much effort, though nice to have), it's clear that adding undo/redo in dialogs must not spoil the application's undo stack (ie. undoing the last action after the hyperlink dialog is closed should not consider every single key stroke). Added needsDevAdvice to understand if a) undo/redo in RichTextBox would be a separate function and b) the effort is acceptable low (easyhackable). No need for further input from UX.
Testing ctrl+z in text input boxes of the Hyperlink dialog and the Find and Replace dialog a kind of undo and redo happens with x11 (gen) and qt5 vcl backends. Nothing seems to happen when ctrl+z is press using gtk3 backend.
gtk4 version has gtk4s built in undo/redo now *** This bug has been marked as a duplicate of bug 134638 ***