Bug 135033 - Undo/redo not supported for animations
Summary: Undo/redo not supported for animations
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Katarina Behrens
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Undo-Redo Object-Animations
  Show dependency treegraph
 
Reported: 2020-07-22 00:58 UTC by Kai
Modified: 2021-12-06 13:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai 2020-07-22 00:58:29 UTC
Description:
It should be possible to undo/redo changing or adding animations to objects.

Steps to Reproduce:
1. Create an object in impress
2. Add an animation
3. Click undo

Actual Results:
It will undo the creation of the object not the addition of the animation.

Expected Results:
Impress should undo adding the animation.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
.
Comment 1 BogdanB 2020-09-18 20:34:49 UTC
Confirm in
Version: 7.1.0.0.alpha0+
Build ID: d57b14e3394b081adf0888ed8dcb7b86d66c246c
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 2 Aron Budea 2020-10-17 12:07:41 UTC
This is a regression (or implementation error, depending on how you look at it): it was fine when there was a separate dialog for adding animations, the undo list shows an "Animation parameters" entry.
It changed when adding the animation was moved to the sidebar in the following commit, since then no such undo entry is created.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e4aa4472f84dc9fcf0acaab80ede005603a4b93c
author		Rishabh Kumar <kris.kr296@gmail.com>	2015-07-16 05:17:52 +0530
committer	Katarina Behrens <Katarina.Behrens@cib.de>	2016-02-04 09:20:04 +0000

tdf#87813: Moving effects list into the animation tab
Comment 3 Eyal Rozenberg 2021-06-12 15:44:15 UTC
Experienced with:

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 162f5a20095c6937030d23ee03fb8f72c51eefa1
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_IL); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-06_16:55:45
Comment 4 Commit Notification 2021-11-16 10:10:49 UTC
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/71a186aedc6060bb4fb834c847f74c657d700f1e

tdf#135033: Make undo of adding and editing animations possible

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2021-11-17 12:26:56 UTC
Verified in

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: fcad2503ede92b515076f9bb3162855dcc2c575d
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Bubli, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ?
Comment 6 Commit Notification 2021-11-17 12:28:24 UTC
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/41b679f73e2001cd2840dd1256911e0b79bacaf8

tdf#135033: Make undo of adding and editing animations possible

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Katarina Behrens 2021-11-17 17:32:33 UTC
> @Bubli, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ?

Yah why not
Comment 8 Eyal Rozenberg 2021-11-17 20:34:30 UTC
Whoo-hoo! Thanks Katarina and everyone involved. This saves me a lot of defensive saving of presentations...
Comment 9 Commit Notification 2021-11-18 13:34:59 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6e04ef6eda7d632ad39b3938ab864417303c8368

tdf#135033: sd: Add UItest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard