Bug 119514 - Undo for image deletion does not restore animations
Summary: Undo for image deletion does not restore animations
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 83882 83928 136288 (view as bug list)
Depends on:
Blocks: Undo-Redo Object-Animations
  Show dependency treegraph
 
Reported: 2018-08-26 17:51 UTC by Diogo G. Sousa
Modified: 2025-07-27 03:09 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Impress - animation not restored after undo (10.21 KB, image/png)
2022-05-20 15:10 UTC, BDF
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo G. Sousa 2018-08-26 17:51:46 UTC
Description:
When you remove an image that had an animation, and then undo this action, the animation is not restores and shows "-1" in place of the object name.

Steps to Reproduce:
1. Insert an image.
2. Add an animation to the image, e.g. Appear.
3. Delete image.
4. Undo.


Actual Results:
Animation is not restored for the image.  You will find an animation that does not belong to any object.

Expected Results:
Animation should be restored.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Diogo G. Sousa 2018-08-26 17:53:35 UTC
Seems to be related, if not a duplicate, of Bug 83882.
Comment 2 Xisco Faulí 2018-08-27 09:38:57 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=57082b1243e86694b72c5e4fad013bf207bfe81a

author	Luke Deller <luke@deller.id.au>	2013-04-28 07:06:11 +1000
committer	David Tardon <dtardon@redhat.com>	2013-04-28 11:52:12 +0000
commit 57082b1243e86694b72c5e4fad013bf207bfe81a (patch)
tree 2e461c166beecb5b569c966a2aeceb90995a4b85
parent 2094610175140023cf8f904f8506c189e36dec06 (diff)
fdo#60910: discard UNO shape object in SdrObject::SetPage
The creation of the UNO shape in SdrObject::getUnoShape is influenced
by pPage, so when the page changes we need to discard the cached UNO
shape so that a new one will be created with the new page.

This replaces my first shot at a fix for fdo#60910 which reinstated a
line to discard the custom shape engine (and consequently the UNO shape) in
SdrObjCustomShape::InvalidateRenderGeometry.  That worked but did more
discarding than was necessary.

Bisected with: bibisect-41max

Adding Cc: to Luke Deller
Comment 3 Xisco Faulí 2018-08-27 09:40:37 UTC
*** Bug 83882 has been marked as a duplicate of this bug. ***
Comment 4 Xisco Faulí 2018-08-27 09:41:06 UTC
*** Bug 83928 has been marked as a duplicate of this bug. ***
Comment 5 Xisco Faulí 2018-11-29 14:42:59 UTC
Still reproduced in

Version: 6.3.0.0.alpha0+
Build ID: 00df4a5ae395607eab1f83aacfc1fb05eb93ecc9
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, since you fixed bug 112696, I thought you might be interested in this issue...
Comment 6 [REDACTED] 2019-12-09 19:12:47 UTC
Still happening with 6.3

Microsoft PowerPoint works!
Comment 7 Kai 2020-07-22 00:47:50 UTC
I can reproduce this exact behavior in 7.0RC2
Comment 8 Telesto 2020-10-16 15:31:29 UTC
*** Bug 136288 has been marked as a duplicate of this bug. ***
Comment 9 Eyal Rozenberg 2021-06-12 15:42:38 UTC
Isn't this just a special case of the fact that there is no undo support for changes/additions/removals of animations, period?

Please explain why not or mark as a duplicate of bug 135033.
Comment 10 BDF 2022-05-20 15:10:34 UTC
Created attachment 180259 [details]
Impress - animation not restored after undo

I can confirm and the bug still exists.

Version: 7.3.3.2 / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: de-AT (de_AT.UTF-8); UI: de-DE
Flatpak
Calc: threaded
Comment 11 QA Administrators 2025-07-27 03:09:22 UTC
Dear Diogo G. Sousa,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug