Bug Hunting Session
Bug 119514 - Undo for image deletion does not restore animations
Summary: Undo for image deletion does not restore animations
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 83882 83928 (view as bug list)
Depends on:
Blocks: Undo-Redo Custom-Animations
  Show dependency treegraph
 
Reported: 2018-08-26 17:51 UTC by Diogo G. Sousa
Modified: 2019-01-08 19:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo G. Sousa 2018-08-26 17:51:46 UTC
Description:
When you remove an image that had an animation, and then undo this action, the animation is not restores and shows "-1" in place of the object name.

Steps to Reproduce:
1. Insert an image.
2. Add an animation to the image, e.g. Appear.
3. Delete image.
4. Undo.


Actual Results:
Animation is not restored for the image.  You will find an animation that does not belong to any object.

Expected Results:
Animation should be restored.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Diogo G. Sousa 2018-08-26 17:53:35 UTC
Seems to be related, if not a duplicate, of Bug 83882.
Comment 2 Xisco Faulí 2018-08-27 09:38:57 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=57082b1243e86694b72c5e4fad013bf207bfe81a

author	Luke Deller <luke@deller.id.au>	2013-04-28 07:06:11 +1000
committer	David Tardon <dtardon@redhat.com>	2013-04-28 11:52:12 +0000
commit	57082b1243e86694b72c5e4fad013bf207bfe81a (patch)
tree	2e461c166beecb5b569c966a2aeceb90995a4b85
parent	2094610175140023cf8f904f8506c189e36dec06 (diff)
fdo#60910: discard UNO shape object in SdrObject::SetPage
The creation of the UNO shape in SdrObject::getUnoShape is influenced
by pPage, so when the page changes we need to discard the cached UNO
shape so that a new one will be created with the new page.

This replaces my first shot at a fix for fdo#60910 which reinstated a
line to discard the custom shape engine (and consequently the UNO shape) in
SdrObjCustomShape::InvalidateRenderGeometry.  That worked but did more
discarding than was necessary.

Bisected with: bibisect-41max

Adding Cc: to Luke Deller
Comment 3 Xisco Faulí 2018-08-27 09:40:37 UTC
*** Bug 83882 has been marked as a duplicate of this bug. ***
Comment 4 Xisco Faulí 2018-08-27 09:41:06 UTC
*** Bug 83928 has been marked as a duplicate of this bug. ***
Comment 5 Xisco Faulí 2018-11-29 14:42:59 UTC
Still reproduced in

Version: 6.3.0.0.alpha0+
Build ID: 00df4a5ae395607eab1f83aacfc1fb05eb93ecc9
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, since you fixed bug 112696, I thought you might be interested in this issue...