Bug 135056 - Freeze hang/after deleting index SwPosition::dumpAsXml
Summary: Freeze hang/after deleting index SwPosition::dumpAsXml
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.5.2 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.2 target:6.4.7
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Bullet-Number-Outline-Lists redlinehide-regressions
  Show dependency treegraph
 
Reported: 2020-07-22 20:00 UTC by Telesto
Modified: 2020-11-19 11:09 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (980.28 KB, application/vnd.oasis.opendocument.text)
2020-07-22 20:00 UTC, Telesto
Details
Bibisect log (2.26 KB, text/plain)
2020-07-22 20:11 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-22 20:00:06 UTC
Description:
Freeze hang/after deleting index SwPosition::dumpAsXml

Steps to Reproduce:
1. Open the attached file
2. Delete the index on page 2

Actual Results:
Freeze/hang

Expected Results:
No freeze/hang


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52820b52b3bca45e2db527d1cc5f4488b2e0b9d0
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-22 20:00:24 UTC
Created attachment 163424 [details]
Example file
Comment 2 Telesto 2020-07-22 20:04:39 UTC
Not in 
6.5/7.0
Comment 3 Telesto 2020-07-22 20:11:04 UTC
Created attachment 163425 [details]
Bibisect log

Bisected to:
author	Michael Stahl <Michael.Stahl@cib.de>	2020-06-19 15:05:42 +0200
committer	Michael Stahl <michael.stahl@cib.de>	2020-06-19 16:42:08 +0200
commit a60dd9ef1361c5925803acaa5292e99277d1faf3 (patch)
tree 5ab4fcb2c8030d1ca0afcd26af3561d3a8f977b0
parent 8e4c79472644452431381733a5e4b21f98fcdcf3 (diff)
tdf#132326 sw_redlinehide: no frames allowed in Undo SwNodesArray
This crashes in SwAccessibleParagraph::GetRealHeadingLevel(); the a11y
should have been disposed earlier because the node it's connected to is
in the Undo SwNodesArray.

When SwUndoDelete::SwUndoDelete() calls SwNodes::MoveNodes(), all
existing frames must be destroyed; the MoveNodes() would reset its flag
temporarily inside a section, to delay creating the frames inside the
section when moving to the live SwNodesArray, but this also prevents
the deletion when moving in the other direction.

(crash is regression from 723728cd358693b8f4bc9d913541aa4479f2bd48)
Comment 4 Telesto 2020-07-22 20:14:18 UTC
Adding CC: to Michael Stahl

-> Current status: unconfirmed (but to speed things up)
Comment 5 Xisco Faulí 2020-07-22 21:16:48 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: b877b9bc894892e61f0d6311729f7b01139923d6
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 6 Commit Notification 2020-09-01 06:16:43 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1d6e919046ed353a9d9d86bb9f0332da2e9dea4d

tdf#135056 sw_redlinehide: when moving sections to undo nodes-array,

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Michael Stahl (allotropia) 2020-09-01 06:18:12 UTC
fixed on master
Comment 8 Commit Notification 2020-09-01 07:54:16 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/dfa0a910aa6ec26956d713d8265cac53b1904462

tdf#135056 sw_redlinehide: when moving sections to undo nodes-array,

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2020-09-03 07:24:57 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/48b796af1d1522119ff7749a63458b29f65f0885

tdf#135056 sw_redlinehide: when moving sections to undo nodes-array,

It will be available in 6.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2020-09-03 09:48:21 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bc46ff73d6f79d850253f9e1896643eb73238ebb

tdf#135056: sw_uiwriter: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Telesto 2020-09-03 19:21:36 UTC
Version: 7.1.0.0.alpha0+ (x64)
Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL