Bug 135060 - Clicking a template in Master Slide Sidebar changes color
Summary: Clicking a template in Master Slide Sidebar changes color
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard: target:7.5.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Master-Slide
  Show dependency treegraph
 
Reported: 2020-07-22 21:12 UTC by himajin100000
Modified: 2022-09-16 09:56 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description himajin100000 2020-07-22 21:12:41 UTC
Description:
see steps to reproduce

Steps to Reproduce:
1. Launch Impress
2. Show [Master Slide] Sidebar
3. In the [Available for use] Section, you can find YELLOW Beehive template
4. Right Click on the template, and select [Apply to All Slides]

Actual Results:
The slide is with blue color area.
the Beehive template change its color to blue


Expected Results:
The slide is with YELLOW color area.
the Beehive template change keep its color i.e. YELLOW.


Reproducible: Always


User Profile Reset: No



Additional Info:
Similar to tdf#134574, but I didn't enable Skia this time.

If the problem is from the similar reason, the culprit could be...
https://opengrok.libreoffice.org/xref/core/sd/source/ui/sidebar/MasterPageDescriptor.cxx?r=b83ac35b#218


Version: 7.1.0.0.alpha0+ (x64)
Build ID: b1c83b68bfbf3477fa6a8f4c79c53f6f9ab31f8e
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: ja-JP (ja_JP); UI: en-US
Calc: CL
Comment 1 Xisco Faulí 2020-08-06 08:38:23 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 76c40b82e6a44539cd43f326c00246e759449571
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 Xisco Faulí 2020-08-06 08:51:21 UTC
Regression introduced by:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca343fca0793361f94660750d14957b725699bfc

author	andreas kainz <kainz.a@gmail.com>	2020-04-18 01:08:03 +0200
committer	andreas_kainz <kainz.a@gmail.com>	2020-04-19 15:38:42 +0200
commit ca343fca0793361f94660750d14957b725699bfc (patch)
tree 7849157027369a708a5a57d7dbe7121010b8059f
parent 0f097b4d05881af59e9f106831080476c7b61093 (diff)
tdf#132138 add Draw Styles support to Beehive Impress template

Bisected with: bibisect-linux64-7.0

Adding Cc: to andreas kainz
Comment 3 QA Administrators 2022-08-07 03:31:07 UTC Comment hidden (obsolete)
Comment 4 Laurent Balland 2022-08-09 10:07:23 UTC
Confirmed with:
- Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
- Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 5 Laurent Balland 2022-09-05 12:52:30 UTC
Same applied to other embedded templates: DNA, Focus (borders are blue), Piano, Vivid,...
Object styles do not seem to included in Master Page. So templates must be rewritten to add format to standard style and not use specific format.

I'm going to try to propose a new BeeHive template.
Comment 6 Laurent Balland 2022-09-07 07:25:16 UTC
Commit under review for BeeHive:
https://gerrit.libreoffice.org/c/core/+/139552

Same should be done for other templates
Comment 7 Stéphane Guillou (stragu) 2022-09-12 15:58:44 UTC
Wondering if this is a duplicate of bug 122080.
Laurent, do you think all templates need to be modified individually to fix this issue?
Comment 8 Laurent Balland 2022-09-12 20:01:32 UTC
(In reply to stragu from comment #7)
> Wondering if this is a duplicate of bug 122080.
> Laurent, do you think all templates need to be modified individually to fix
> this issue?

Each template has a different history, and use or not some styles. When applying a master slide, standard style used is the one of the current presentation, not the standard style of the template. This causes reverting to standard blue of some elements.
To correct this bug, I propose to modify the style hierarchy in styles.xml of each damage template (if a template uses a picture and no elements, there is no bug):
- BeeHive: https://gerrit.libreoffice.org/c/core/+/139552
- Blue_Curve: https://gerrit.libreoffice.org/c/core/+/139768
- DNA: https://gerrit.libreoffice.org/c/core/+/139774
- Focus: https://gerrit.libreoffice.org/c/core/+/139767
- Forestbird: https://gerrit.libreoffice.org/c/core/+/139766
- Inspiration: https://gerrit.libreoffice.org/c/core/+/139631
- Piano: https://gerrit.libreoffice.org/c/core/+/139780
- Progress: https://gerrit.libreoffice.org/c/core/+/139773
- Sunset: https://gerrit.libreoffice.org/c/core/+/139776
- Vivid: https://gerrit.libreoffice.org/c/core/+/139779

I did not notice any problem with other templates. Feel free to add any feedback.
Comment 9 Commit Notification 2022-09-14 09:31:53 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83c0ffb6e744a2338845532efc103e132fc74bbb

tdf#135060 Modify Progress template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-09-14 09:34:04 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/531652352b3be6504c2f68ba4220edc7c236cb01

tdf#135060 Modify DNA template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-09-14 09:35:17 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9242e6f49647a4247967ceb3a621a27d0a4e021c

tdf#135060 Modify Blue_Curve template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-09-14 09:36:27 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4adc07f4ab5f44b4bf60ae01e508d7c29682790

tdf#135060 Modify Forestbird template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2022-09-14 09:37:37 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a4226f8afc6c2e6026581b41f2149024f04cdf04

tdf#135060 Modify Focus template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-09-14 09:37:46 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/38160bc630567aa5d1384528516983ec17866edb

tdf#135060 Modify Inspiration template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2022-09-14 09:37:56 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4ae293276133a12a8251585b6a37896907bbd67e

tdf#135060 Modify BeeHive template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2022-09-14 09:53:19 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2f76e7baba6e86ab2eee493e432d6bf8932f07c5

tdf#135060 Modify Piano template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2022-09-14 18:11:05 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/84cfd8c856e5d564e33b93cf3f8cf6ffe3df3793

tdf#135060 Modify Sunset template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2022-09-14 18:12:37 UTC
Laurent BP committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3274fd1b9bfd04ca018c98084689cb9a810a350b

tdf#135060 Modify Vivid template

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Laurent Balland 2022-09-16 09:56:45 UTC
(In reply to stragu from comment #7)
> Wondering if this is a duplicate of bug 122080.
No it is not the same problem