Description: Track and changes show doesn't show the expected bullets Steps to Reproduce: 1. Open the attached file 2. Select the text from bottom to the first bullet starting with: Les algorithmes 3. Backspace 4. Press a few times backspace so the bullet disappears and cursor moves the previous line 5. Show track changes Actual Results: No bullets Expected Results: Bullets still present Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.2 Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded
Created attachment 163725 [details] Sample file
Can't reproduced in: Version: 7.1.0.0.alpha0+ Build ID: ce6c6a5ad6c9dde09bb0bb0c51e16d828cfe0ef7 CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (hu_HU.UTF-8); UI: en-US Calc: threaded and not in: Version: 7.1.0.0.alpha0+ (x64) Build ID: c10ea0e903ee2aba126087fc81702233b3a509cf CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded MacOS only?
Created attachment 164500 [details] Screencast
They STR might be bit hard to understand.. added a screencast
(In reply to Telesto from comment #4) > They STR might be bit hard to understand.. added a screencast Thanks, yeah my bad, reproduced in: Version: 7.1.0.0.alpha0+ Build ID: ce6c6a5ad6c9dde09bb0bb0c51e16d828cfe0ef7 CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (hu_HU.UTF-8); UI: en-US Calc: threaded
Bibisected using linux-64-6.3 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=32902f66e7749b2d06d13f50416be5323a0c0ea9 author: Michael Stahl <Michael.Stahl@cib.de> committer: Michael Stahl <Michael.Stahl@cib.de> summary: sw_redlinehide: make layout based Show/Hide mode the default Adding CC: Michael Stahl
I'm not sure the previous behavior was correct, as it didn't show the distinction between deleting a bulleted entry, and deleting first the entry, then the bullet. In fact, if you enable showing changes from the start, the bullet already wasn't shown after the steps in LO 3.3.0. Probably the solution would be to differentiate between how these changes are displayed.
this happens because Backspace is handled specially to remove numbering from an empty paragraph. if you first Show the tracked changes, then backspace like in the description, the result was different in LO 6.1: the result is that the paragraph is not in a list, but still indented - now Hide and Show tracked changes, and it's still not in a list, but no longer indented. on master this works better, as the backspacing removes the indent as well, so it looks the same after editing as after a subsequent Hide/Show. so the problem here is that there is no recording of the actual formatting change when the numbering is removed - this has never been implemented for editing (although László Németh added something for imported tracked changes relatively recently, which i haven't had an opportunity to test). without being able to store the previous formatting, this can't really work and so i think the scenario in this bug isn't really a regression, it just happened to work in different case back then than it does now.
repro 24.2+
In OPs description, he says actual results are "no bullets" at all (repro 24.2+), but at comment 6's commit only the first paragraph lost the bullet point. The "no bullets on all redlined paragraphs" started with 6.4 commit 2f2409fdac98cc3470ad8fa1d45ab84bb50e929c Author: László Németh on Fri Aug 2 13:14:11 2019 +0200 tdf#127097 Change tracking: change style of whole deletion at paragraph join Likely all this will be fixed if regression bug 139685 is solved.
(In reply to Michael Stahl (allotropia) from comment #8) > this happens because Backspace is handled specially to remove numbering That is when sw/source/uibase/docvw/edtwin.cxx KEY_BACKSPACE calls rSh.NumOrNoNum