Download it now!
Bug 135405 - Dictionaries: Add Korean(ko_KR) spellcheck dictionary from existing hunspell Korean dictionary project
Summary: Dictionaries: Add Korean(ko_KR) spellcheck dictionary from existing hunspell ...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Ilkyu Ju
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: CJK-Korean
  Show dependency treegraph
 
Reported: 2020-08-03 09:09 UTC by Ilkyu Ju
Modified: 2020-11-11 13:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example of Huspell-ko dictionary on LibreOffice (366.52 KB, image/png)
2020-08-11 16:23 UTC, DaeHyun Sung
Details
Example of Huspell-ko dictionary on LibreOffice. (107.86 KB, image/png)
2020-08-11 16:24 UTC, DaeHyun Sung
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilkyu Ju 2020-08-03 09:09:41 UTC
Description:
Hello,

Currently, there is no spellcheck dictionary available for Korean(ko_KR) on LibreOffice. However, a Korean spellcheck dictionary for hunspell already exists and can be obtained from https://github.com/spellcheck-ko/hunspell-dict-ko . This project is based on the dictionary data from reliable sources maintained by the National Institute of Korean Language of South Korea.

So, I would like to propose to add a Korean spellcheck dictionary for LibreOffice, using the `spellcheck-ko/hunspell-dict-ko` dictionary on GitHub. Let me know if I can give a helping hand on this.

Thank you!

Actual Results:
 

Expected Results:
 


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Ming Hua 2020-08-03 19:10:02 UTC
Valid request, setting to NEW.

However, there doesn't seem to be a lot of people working on CJK features now.  So it's probably up to Korean LibreOffice users to implement this.

I personally have no experience about hunspell-based spellcheckers.  One suggestion may be trying to create an extension first.  There are several spellcheckers for other languages available on extensions.libreoffice.org.
Comment 2 Ilkyu Ju 2020-08-04 04:53:50 UTC
(In reply to Ming Hua from comment #1)
> Valid request, setting to NEW.
> 
> However, there doesn't seem to be a lot of people working on CJK features
> now.  So it's probably up to Korean LibreOffice users to implement this.
> 
> I personally have no experience about hunspell-based spellcheckers.  One
> suggestion may be trying to create an extension first.  There are several
> spellcheckers for other languages available on extensions.libreoffice.org.

Thank you very much for the advice. Turns out there actually is a Korean spellchecking extension based on the same hunspell dictionary data I mentioned, which can be found on https://extensions.libreoffice.org/en/extensions/show/korean-spellchecker . I have tried using the extension and it seems to work great, just needs an update of its dictionary data to the latest version.

At the same time, I have also submitted a patch which adds ko_KR dictionary to the dictionaries repo (https://gerrit.libreoffice.org/c/dictionaries/+/100036). I was just wondering which is a better move, (1) Update the existing Korean spellchecking extension, or (2) Add a ko_KR dictionary to dictionaries repo?
Comment 3 Ming Hua 2020-08-05 15:19:06 UTC
(In reply to Ilkyu Ju from comment #2)
[...]
> I was just
> wondering which is a better move, (1) Update the existing Korean
> spellchecking extension, or (2) Add a ko_KR dictionary to dictionaries repo?
According to the "Overview" paragraph on the https://git.libreoffice.org/core/ page, the approach of directly integrating into LibreOffice is preferred over the approach of extension.

However I'm not a developer, and don't know the exact pros and cons of these two different ways.  So it's probably best to ask the developers directly, either on the developers mailing list (where you already sent your license statement) or IRC (#libreoffice-dev on Freenode).

Good luck.
Comment 4 DaeHyun Sung 2020-08-11 16:22:08 UTC
I'm LibreOffice Korean User. 
I checked the submit the commit, " tdf#135405 Add Korean(ko_KR) spellcheck dictionary ". 
Below is the link.
https://gerrit.libreoffice.org/c/dictionaries/+/100395 

I built and checked the feature on LibreOffice, MacOSX Environment.

LGTM.

The code origins from huspell-ko by Korean Debian Developer, "Changwoo Ryu". Also, It usually uses in the Korean Linux environment.

If the feature is problem, You can upload the isssue.

Below is huspell-ko issue page link.
https://github.com/spellcheck-ko/hunspell-dict-ko/issues
Comment 5 DaeHyun Sung 2020-08-11 16:23:51 UTC
Created attachment 164171 [details]
Example of Huspell-ko dictionary on LibreOffice

Example of Huspell-ko dictionary on LibreOffice.
숫닭(incorrect) to 수탉(correct)
Comment 6 DaeHyun Sung 2020-08-11 16:24:45 UTC
Created attachment 164173 [details]
Example of Huspell-ko dictionary on LibreOffice.

Example of Huspell-ko dictionary on LibreOffice.
어루만자기(incorrect) to 어루만지기(correct)
Comment 7 DaeHyun Sung 2020-09-05 08:13:50 UTC
(In reply to DaeHyun Sung from comment #6)
> Created attachment 164173 [details]
> Example of Huspell-ko dictionary on LibreOffice.
> 
> Example of Huspell-ko dictionary on LibreOffice.
> 어루만자기(incorrect) to 어루만지기(correct)

I tested it on my laptop both  openSUSE Tumbleweeds and Windows 10. 

Linux
Version: 7.1.0.0.alpha0+
Build ID: 6935dcd80f1677a293a412da3d94afd1217c0bd1
CPU threads: 16; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ko-KR (ko_KR.UTF-8); UI: ko-KR
Calc: threaded

Windows
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 6935dcd80f1677a293a412da3d94afd1217c0bd1
CPU threads: 6; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: ko-KR (ko_KR); UI: ko-KR
Calc: threaded
Comment 8 Commit Notification 2020-10-28 09:46:54 UTC
Ilkyu Ju committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/dictionaries/commit/975046e0970d4300bb229fb0cbe3d5d0afec8c8f

tdf#135405 Add Korean(ko_KR) spellcheck dictionary