Bug 135475 - Scrambled / overlapped text in column caused by a certain image (STR in comment 8); layout loop when trying to fix it
Summary: Scrambled / overlapped text in column caused by a certain image (STR in comme...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: Layout-Loops, Writer-Loops Page-Layout-Columns
  Show dependency treegraph
 
Reported: 2020-08-05 19:24 UTC by Telesto
Modified: 2023-11-14 11:30 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (225.32 KB, application/vnd.oasis.opendocument.text)
2020-08-05 19:24 UTC, Telesto
Details
File for do it your self (21.35 KB, application/vnd.oasis.opendocument.text)
2020-08-05 19:25 UTC, Telesto
Details
Image (203.96 KB, image/png)
2020-08-05 19:25 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-05 19:24:30 UTC
Description:
Scrabbled text on file open caused by image

Steps to Reproduce:
1. Open the attached file. Look at the second column

2. Open the attached file (from scratch)
3. Download the image
4. Place cursor before the marked text
5. Insert image -> Pick the download image

Actual Results:
Scrambled text

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: ru-RU (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-08-05 19:24:45 UTC
Created attachment 163986 [details]
Example file
Comment 2 Telesto 2020-08-05 19:25:14 UTC
Created attachment 163987 [details]
File for do it your self
Comment 3 Telesto 2020-08-05 19:25:28 UTC
Created attachment 163988 [details]
Image
Comment 4 Telesto 2020-08-05 19:27:59 UTC
Also found in
3.3.0
Comment 5 Dieter 2021-03-05 17:33:25 UTC
Telesto, unfortunately nothing has happened with this bug report for more than half year. So I'd like to ask, if it is still valid. Could you please try to reproduce it with the latest version of LibreOffice?
=> NEEDINFO
Comment 6 Telesto 2021-03-05 19:41:05 UTC
Still around
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 722ec600e85cca2e94e82e69f8d13773061172b9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 7 Dieter 2021-03-06 05:57:52 UTC
I can confirm it, but only with your image from comment 3

Version: 7.1.1.2 (x64) / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 8 Telesto 2021-03-07 09:48:49 UTC
(In reply to Dieter from comment #7)
> I can confirm it, but only with your image from comment 3
> 
> Version: 7.1.1.2 (x64) / LibreOffice Community
> Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
> CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL:
> win
> Locale: de-DE (de_DE); UI: en-GB
> Calc: CL

Correction:
2. Open the attached file (from scratch)
3. Download the image
4. Place cursor AFTER the marked text
5. Insert image -> Pick the download image
Comment 9 Telesto 2021-03-07 09:57:09 UTC
Lets focus the creating of such a document.. so comment 8.. because this is actually an regression

Not in
Versie: 6.3.0.4 (x86)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-taal: nl-NL
Calc: CL

found in
6.4
Comment 10 raal 2021-10-02 20:31:42 UTC
This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna; Could you possibly take a look at this one?
Thanks
 135aa137d62e6fda825a468302eeeee4b24ff431 is the first bad commit
commit 135aa137d62e6fda825a468302eeeee4b24ff431
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Nov 20 00:08:03 2019 +0100

    source a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db

https://git.libreoffice.org/core/+/a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db
   sw: insert image: set anchor to at-char by default
Comment 11 Miklos Vajna 2021-10-05 13:54:12 UTC
I think the above just exposed a pre-existing bug, so this is rather an implementation error. If I revert the above commit on master but go to tools -> options -> writer -> formatting and set the default anchor type to at-char, the same happens.

Inspecting the layout, this is clearly broken: the middle column has multiple text frames, and the first two overlaps. The first text frame top is at 1418 twips, it starts with a fly portion that has a height of 2851, so bottom of the portion is 4269 (and actual text only starts below that). In contrast to this, the 2nd text frame in that middle column already starts at 3074 twips.

So yes, this is a bug, but it was there before as well. Adjusting keywords accordingly.
Comment 12 Stéphane Guillou (stragu) 2023-11-14 11:30:10 UTC
Attachment 163986 [details] now looks different at fileopen, since 7.6 and e40263b12055cbb95bb64ec6e81d3912152df900 (cherrypick of trunk's 61a78a523a6131ff98b5d846368e5626fe58d99c): no overlap, but quite a bit of text missing.
Overlap is still reproducible when starting with do-it-yourself attachment 163987 [details].

With attachment 163986 [details], I can also reproduce a layout loop, one core stuck at 100%: place cursor before text right after image, press Enter.
OOo 3.3 would crash shortly after doing that.