Bug 156724 - Document layout changed in PDF export: content overlaps footnote
Summary: Document layout changed in PDF export: content overlaps footnote
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.1 target:7.6.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: PDF-Export
  Show dependency treegraph
 
Reported: 2023-08-10 22:58 UTC by Gabor Kelemen (allotropia)
Modified: 2024-06-26 16:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the expected (from LO 7.2) and 24.2 exported PDF side by side (400.44 KB, image/png)
2023-08-10 22:58 UTC, Gabor Kelemen (allotropia)
Details
Bad export PDF from fresh linux-bibisect 24.2 (112.38 KB, application/pdf)
2023-08-10 22:58 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-08-10 22:58:07 UTC
Created attachment 188920 [details]
Screenshot of the expected (from LO 7.2) and 24.2 exported PDF side by side

In command line PDF export mode attachment 69599 [details] layout has changed.

1. Download attachment 69599 [details]
2. in CLI save as PDF: --convert-to pdf

-> Layout changes, body text is overlapping the footnote. Fine if saved from UI.

Note that layout was not really good to begin with, the document is 7 pages but only the first two was exported to PDF. That started in 6.2, a separate issue.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0d571ff8079f858a5650bf6cbb38296d22cc58e1
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Started in 7.5 with:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c605283ad6785dea762feab5fdffd9d27e75c292

author	Michael Stahl <michael.stahl@allotropia.de>	2022-07-11 19:20:33 +0200
committer	Michael Stahl <michael.stahl@allotropia.de>	2022-07-13 16:58:05 +0200
commit c605283ad6785dea762feab5fdffd9d27e75c292 (patch)

sw: fix spurious layout invalidation from ~SwCallLink()
Comment 1 Gabor Kelemen (allotropia) 2023-08-10 22:58:54 UTC
Created attachment 188921 [details]
Bad export PDF from fresh linux-bibisect 24.2
Comment 2 Commit Notification 2023-08-14 19:15:55 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/610c6f02b11b4b4c555a78b0feb2a1eb35159e39

tdf#156724 tdf#156722 tdf#156745 sw: layout: partially remove IsPaintLocked()

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-08-15 07:45:11 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/61a78a523a6131ff98b5d846368e5626fe58d99c

tdf#156724 tdf#156722 sw: layout: remove IsPaintLocked() check

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2023-08-15 07:51:22 UTC
fixed on master
Comment 5 Commit Notification 2023-08-21 10:07:02 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/cff929fe5c5bc24be81218ba2ce3d9304d09bf68

tdf#156724 tdf#156722 tdf#156745 sw: layout: partially remove IsPaintLocked()

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-08-21 10:27:10 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/e40263b12055cbb95bb64ec6e81d3912152df900

tdf#156724 tdf#156722 sw: layout: remove IsPaintLocked() check

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-08-24 10:44:03 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c303981cfd95ce1c3881366023d5495ae2edce97

tdf#156724 sw: layout: fix tables not splitting due to footnotes differently

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-09-26 11:38:41 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5b3fcbf23773ea8d039185dec2b9704981833473

tdf#156724 sw: layout: fix tables not splitting due to footnotes differently

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 BogdanB 2023-09-28 18:54:36 UTC
Exported using CLI
instdir/program/soffice --convert-to pdf /home/bogdan/Poze/PrintWeek.odt
convert /home/bogdan/Poze/PrintWeek.odt as a Writer document -> /home/bogdan/Documente/LibreOffice7.6/core/PrintWeek.pdf using filter : writer_pdf_Export

The footnote from page 1 it's ok now.
Michael, thanks for fixing this bug.

Verified with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bbe4d3498c2f994342b4d213f0ae874e7b0b7775
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Commit Notification 2024-06-26 16:28:51 UTC Comment hidden (obsolete)
Comment 11 Michael Stahl (allotropia) 2024-06-26 16:40:27 UTC
comment #10 was commit for bug 161348 with wrong bug number