Bug 157096 - CRASH: removing everything in document
Summary: CRASH: removing everything in document
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium critical
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.2
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: Writer-Tables Crash
  Show dependency treegraph
 
Reported: 2023-09-05 07:52 UTC by Xisco Faulí
Modified: 2023-10-27 10:57 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
gdb bt (7.88 KB, text/plain)
2023-09-05 17:43 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2023-09-05 07:52:35 UTC
Steps to reproduce:
1. Open attachment 89157 [details] from bug 71584
2. Select all
3. Delete

-> Crash

Reproduced in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9bb4fa71c230a34a07ea9b7c4e4f13f4d3f7b5fe
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2023-09-05 07:53:17 UTC
Regression introduced by:

author	Michael Stahl <michael.stahl@allotropia.de>	2023-08-23 15:50:59 +0200
committer	Michael Stahl <michael.stahl@allotropia.de>	2023-08-24 12:43:25 +0200
commit c303981cfd95ce1c3881366023d5495ae2edce97 (patch)
tree 4c21d572ebbb0440451a82d4969c54221e550b96
parent 7b1c03ed87f7a21606e09863b23074e6b96e26d1 (diff)
tdf#156724 sw: layout: fix tables not splitting due to footnotes differently

Bisected with: bibisect-linux64-24.2

Adding Cc: to Michael Stahl
Comment 2 m_a_riosv 2023-09-05 12:12:28 UTC
Repro in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cc7d6211bc01e5ec84dbad542605d2e93dea925c
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
Comment 3 Julien Nabet 2023-09-05 17:43:22 UTC
Created attachment 189372 [details]
gdb bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 4 Julien Nabet 2023-09-05 17:48:51 UTC
I confirm I don't reproduce the crash when reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=c303981cfd95ce1c3881366023d5495ae2edce97
Comment 5 Commit Notification 2023-09-15 16:02:34 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a33420923c76d3e282f6d4ce0f3a63616ca3cff

tdf#157096 sw: layout: fix UAF crash from stale mpFlyDestory entry

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Stahl (allotropia) 2023-09-15 16:37:50 UTC
fixed on master
Comment 7 Commit Notification 2023-09-18 06:58:40 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/8b6485703af3af575fb0cd5fa38267c86545185e

tdf#157096 sw: layout: fix UAF crash from stale mpFlyDestory entry

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-10-27 10:57:13 UTC
OmkarAcharekar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ae9c207675f1144fdea8f628f370375768f1eb00

tdf#157096: sw_layout: Add test for CRASH removing everything in document

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.