Bug 135554 - Bad layout for extra options in save dialog
Summary: Bad layout for extra options in save dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: File-Dialog
  Show dependency treegraph
 
Reported: 2020-08-08 12:48 UTC by Arnaud Versini
Modified: 2022-03-21 07:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Save dialog (37.91 KB, image/png)
2020-08-08 12:49 UTC, Arnaud Versini
Details
Situation with gtk3 (on KDE) (18.64 KB, image/png)
2020-08-12 08:54 UTC, Heiko Tietze
Details
Situation with generic VCL (11.52 KB, image/png)
2020-08-12 08:57 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arnaud Versini 2020-08-08 12:48:57 UTC
Description:
Hello,

A lot of space is used for internal options and waste a lot of space in the dialog. I don't say those options are useless of course but just we should use a better way to include them in the dialog

Steps to Reproduce:
1. Just open the save dialog

Actual Results:
A lot of space wasted in the save dialog

Expected Results:
Less space for LO saving options


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
Threads CPU : 4; OS : Windows 10.0 Build 19041; UI Render : Skia/Vulkan; VCL: win
Locale: fr-FR (fr_FR); Langue IHM : fr-FR
Calc: threaded
Comment 1 Arnaud Versini 2020-08-08 12:49:58 UTC
Created attachment 164046 [details]
Save dialog
Comment 2 Heiko Tietze 2020-08-12 08:54:44 UTC
Created attachment 164184 [details]
Situation with gtk3 (on KDE)

Not wrapped but badly aligned on KDE.
Comment 3 Heiko Tietze 2020-08-12 08:57:29 UTC
Created attachment 164185 [details]
Situation with generic VCL

Not wrapped, still badly aligned, and unclear second row (users wonder why this particular item is placed apart).
Comment 4 Heiko Tietze 2020-08-12 09:00:11 UTC
This would be my take:
* Do not wrap lines on Windows
* Align with the filter dropdown controls, if possible
* Do not put items in a second or third row
Comment 5 Jan-Marek Glogowski 2020-08-14 04:39:54 UTC
(In reply to Heiko Tietze from comment #2)
> Created attachment 164184 [details]
> Situation with gtk3 (on KDE)
> 
> Not wrapped but badly aligned on KDE.

Just FYI: the "extension selection" checkbox is a KDE feature, so we have to ignore LO's own setting, or we would get two of them. That checkbox is placed by KDE, so there is nothing we can do about the alignment, since we just get the area below for our own layout.
Comment 6 Heiko Tietze 2020-08-14 08:50:16 UTC
(In reply to Heiko Tietze from comment #4)
> This would be my take:
> * Do not wrap lines on Windows
> * Align with the filter dropdown controls, if possible
> * Do not put items in a second or third row

Discussed this in the design meeting and "Save with password" and "Encrypt with GPG key" could be placed in a second column.

The "Edit filter settings" applies only for text with encoding; but the dialog shows up in any case. According the help it applies information at the file header and we may put this option in the extra dialog (or just remove the option). Depends likely on the module and could be useful for Calc.

The automatic extension feature is not working reliably.

(In reply to Jan-Marek Glogowski from comment #5)
> Just FYI: the "extension selection" checkbox is a KDE feature, so we have to
> ignore LO's own setting...
JMux is right, screenshot was made with kde5 VCL. The top-most checkbox is not there in case of gtk3.
Comment 7 michaelandersen 2021-02-22 13:06:00 UTC Comment hidden (spam)
Comment 8 Heiko Tietze 2021-07-14 13:56:42 UTC
Done at Gtk3KDE5FilePicker::addCustomControl(), for example. Seems not so easy to fix.
Comment 9 Andreas Heinisch 2022-03-21 07:20:43 UTC
At least on Win it is not possible to fix this like in Bug 74443.