Bug 135661 - Image position broken after undo save & reload (and causes save error for DOCX)
Summary: Image position broken after undo save & reload (and causes save error for DOCX)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.2 target:6.4.7
Keywords: dataLoss
Depends on:
Blocks:
 
Reported: 2020-08-12 10:35 UTC by Telesto
Modified: 2020-09-03 15:39 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file (11.27 KB, application/vnd.oasis.opendocument.text)
2020-08-12 10:35 UTC, Telesto
Details
Example file more basic (10.55 KB, application/vnd.oasis.opendocument.text)
2020-08-12 10:39 UTC, Telesto
Details
Example file (10.52 KB, application/vnd.oasis.opendocument.text)
2020-08-12 10:41 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-12 10:35:08 UTC
Description:
Image position broken after undo save & reload

Steps to Reproduce:
1. Open the attached file
2. Toggle formatting marks on
3. Inside cell A1 (left top cell) -> delete the second paragraph
4. Gallery item disappears.. 
5. CTRL+Z to reverse
6. Save & reload

Actual Results:
Image at different position

Expected Results:
Save as saved state


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: ru-RU (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-08-12 10:35:35 UTC
Created attachment 164194 [details]
Example file
Comment 2 Telesto 2020-08-12 10:39:09 UTC
Created attachment 164195 [details]
Example file more basic
Comment 3 Telesto 2020-08-12 10:41:57 UTC
Created attachment 164196 [details]
Example file

1. Press delete
2. Undo
3. Save & reload
Comment 4 Telesto 2020-08-12 14:46:04 UTC
The problem appeared with the modified anchoring behavior. The save error might be bug 135016, but is also present in this case
Comment 5 Michael Stahl (allotropia) 2020-08-31 12:01:01 UTC
comment #3 is from:

commit 2d89b9929e85bede4c72684a12e7508751875f0e
Author:     Michael Stahl <Michael.Stahl@cib.de>
AuthorDate: Mon Jun 15 13:11:29 2020 +0200

    tdf#133957 sw: SelectAll should select fly in empty section
    
    Ctrl+A should select everything in the section; if the section is empty,
    there's no text to select, and then the shell will cancel the selection
    because SwCursorShell::HasSelection() returns false - so check if
    there are flys anchored there, which fixes the Copy.
    
    To fix Delete, a few more checks for empty selection need to be changed.
Comment 6 Commit Notification 2020-09-01 06:16:28 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a609bc9cc03a0a23c8f20fee808cc6cc2887170d

tdf#135661 sw: fix Undo of text deletion of SdrObject

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Michael Stahl (allotropia) 2020-09-01 06:19:06 UTC
fixed on master
Comment 8 Commit Notification 2020-09-01 07:54:04 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/921021b5d208fef12854bcf878489b1c05cde136

tdf#135661 sw: fix Undo of text deletion of SdrObject

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2020-09-01 07:55:30 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/ab7e70f986938a195ef22a836f451124628d47d9

tdf#135661 sw: fix Undo of text deletion of SdrObject

It will be available in 6.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2020-09-03 15:39:01 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3b8ce74e48703877c73c7bcdb5ada1fbee74cc81

tdf#135661: sw_uiwriter: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.