Bug 135726 - Chapter numbering change cannot be undone
Summary: Chapter numbering change cannot be undone
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks: Heading-Numbering Undo-Redo
  Show dependency treegraph
 
Reported: 2020-08-13 16:07 UTC by Thomas Lendo
Modified: 2023-08-13 15:16 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2020-08-13 16:07:44 UTC
Changes in chapter numbering cannot be undone.

Steps to reproduce:
1. Open https://bugs.documentfoundation.org/attachment.cgi?id=164277 (from bug 135725).
2. Open Tools > Chapter Numbering with tab Numbering.
3. Change the chapter numbering of Heading 1 from "Start at: 1" to "Start at: 2" (or change the number style from 1 to A or change the numbering alignment from Left to Right).
4. Click OK.
5. Try to click at the Undo button or Ctrl+Z.

Result:
Undo is not possible.

Expected result:
Changes in the chapter numbering should always be able to be undone by the user.
Comment 1 Dieter 2020-08-14 15:49:49 UTC
I confirm it with

Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 2 BogdanB 2021-07-27 04:57:04 UTC
Still the same in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 3 Sophie Sipasseuth 2023-07-04 09:05:06 UTC
No repro

Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: c94961c6869c34b3874d21cfaa5ec1488609acfe
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL

With this version of LO, there is also no problem with the undo option, but when I want to start my chapter at 2 or 3, nothing happens, the chapter still begins at 1.

Version: 7.5.0.1.0+ (X86_64) / LibreOffice Community
Build ID: ced8585bcb92aa58ca3e24197ff38fb82cc8a703
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL threaded
Comment 4 Sophie Sipasseuth 2023-07-04 09:08:56 UTC
With this version of LO, it is the same as with LO7.5, no problem with the undo option, but when I want to start my chapter at 2 or 3, the chapter still begins at 1.

Version: 7.6.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 1b5cee822e0bc15ddbdfc86926678ca35ab3e082
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL threaded
Comment 5 Stéphane Guillou (stragu) 2023-07-13 16:24:40 UTC
Thanks Sophie! Reproduced in 7.2.7.2, but not reproduced in 7.3.7.2

Issue was in OOo 3.3, so inherited.

Fix bibisected with linux-64-7.3 repo to 28522fa68fbf6e27f87542891cdb035e07d696f2 which points to:

commit 4edf3a964e764dcc40be729b8305476c5b968f1c
author	Vasily Melenchuk <vasily.melenchuk@cib.de>	Fri Jul 23 14:28:04 2021 +0300
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	Thu Aug 05 18:33:54 2021 +0200
sw: undo/redo for outline modification
Outline changes done via "Tools"->"Chapter Numbering" were
not tracked by undo/redo before.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119405

Thanks Vasily and everyone else!