Description: Undo deletes images not even inside the scope of changes Steps to Reproduce: 1. open the attached file 2. Press Enter at the start of the bullet 3. CTRL+Z 4. CTRL+Z Actual Results: Image gone Expected Results: Not so Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 164521 [details] Example file
Found in Version: 6.3.0.0.beta1+ (x86) Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL not in Version: 6.2.0.0.alpha0+ Build ID: 401cba4c20fbc930f034168872642428d7459218 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL
Created attachment 164523 [details] Screencast
Reproduced in: Version: 7.1.0.0.alpha0+ Build ID: ce6c6a5ad6c9dde09bb0bb0c51e16d828cfe0ef7 CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (hu_HU.UTF-8); UI: en-US Calc: threaded
bibisect with bibisect-linux-64-6.3 not successful, lots of crashes and sometimes picture missing after the file open.
This is a reasonably tight range of good and bad states: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=59bdf21f4d933835e158b1f94f29d7b273a4b154..df1adbec35df3cdb16b97cf8a9b85bf4a935ff41 At this point the image is already hidden at start (this might've started earlier in the range, I haven't bibisected further): https://cgit.freedesktop.org/libreoffice/core/commit/?id=32902f66e7749b2d06d13f50416be5323a0c0ea9 author Michael Stahl <Michael.Stahl@cib.de> 2018-11-30 17:54:41 +0100 committer Michael Stahl <Michael.Stahl@cib.de> 2018-12-18 17:55:30 +0100 "sw_redlinehide: make layout based Show/Hide mode the default" This is where LO starts eating up the memory when opening the sample: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6aaae44da382f4bc3eafc287b4a21734b740cf21 author Michael Stahl <Michael.Stahl@cib.de> 2018-12-18 19:19:37 +0100 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> 2018-12-18 23:18:14 +0100 "sw_redlinehide_4b: visibility of flys anchored at empty nodes" The following fixes LO gobbling up all the memory, and results in the current behavior: https://cgit.freedesktop.org/libreoffice/core/commit/?id=df1adbec35df3cdb16b97cf8a9b85bf4a935ff41 author Michael Stahl <Michael.Stahl@cib.de> 2018-12-20 12:57:24 +0100 committer Michael Stahl <Michael.Stahl@cib.de> 2018-12-20 14:26:49 +0100 "sw_redlinehide: don't return COMPLETE_STRING from MapModelToView()" Adding CC: to Michael Stahl.
can't reproduce this on master e2f4e65a7b8024c00b049eebf0d87637efda7f24
It's still present with the build of today (TB77 build) as seen in the screencast Version: 7.1.0.0.alpha0+ (x64) Build ID: 1e0cfd5662d95cea84e80e4fe10d52c3b1101ae6 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Still present Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
It's working as expected if you show changes first hide them changes again and pressing Enter undo undo afterwards
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/98ae340307786c8fe18addc3714c9b859fdf12dd tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodes It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/f4740811b65076d9a84c098f466a02143fcfec06 tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodes It will be available in 7.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/78f726541be4316a8fe18c50f7d146304f6e0e87 tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodes It will be available in 7.2.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-3-3": https://git.libreoffice.org/core/commit/5706653d0eb1dff015712181a1e27a0785376200 tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodes It will be available in 7.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
oh right i fixed this didn't i
Verified in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4e2ce2a460458f17ee4360c45a2da2fc4b4d753e CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: threaded Inserting a new paragraph at the beginning and undoing does not make the caption frame disappear.