Bug 136223 - Opening a specific PPTX in debug build produces a failing assert related to Skia
Summary: Opening a specific PPTX in debug build produces a failing assert related to Skia
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords: haveBacktrace
Depends on:
Blocks: Crash-Assert Skia
  Show dependency treegraph
 
Reported: 2020-08-28 12:27 UTC by Mike Kaganski
Modified: 2020-10-07 11:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
A PPTX with images and Chinese script (2.20 MB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-08-28 12:27 UTC, Mike Kaganski
Details
bt with debug symbols + some console logs (6.57 KB, text/plain)
2020-09-04 10:33 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-08-28 12:27:32 UTC
Created attachment 164800 [details]
A PPTX with images and Chinese script

Opening the attachment with a debug build of current master gives this message:

---------------------------
Microsoft Visual C++ Runtime Library
---------------------------
Debug Error!

Program: C:\lo\src\build\instdir\program\soffice.bin

abort() has been called

(Press Retry to debug the application)

---------------------------
Abort   Retry   Ignore   
---------------------------

Tested with Version: 7.1.0.0.alpha0+ (x64)
Build ID: 490cab0539660aa8e1b51f0555b890f69940c04d
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: CL
Comment 1 Julien Nabet 2020-09-04 10:33:39 UTC
Created attachment 165136 [details]
bt with debug symbols + some console logs

On pc Debian x86-64 with master sources updated today + gen rendering + SAL_FORCESKIA=1

I noticed this log:
warn:legacy.osl:763992:763992:vcl/source/outdev/bitmap.cxx:448: CopyBits with zero or negative width or height
Comment 2 Julien Nabet 2020-09-04 10:34:16 UTC
(Argh, I hadn't finished my sentence)
... I could reproduce this.
Comment 3 Commit Notification 2020-09-25 18:17:16 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4eb816de71f1310a3a5d9803f7355849e6273439

do not assert for slow alpha blending if mirroring is used (tdf#136223)

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2020-09-25 18:25:44 UTC
On pc Debian x86-64 with master sources updated today + enable-dbgutil, I don't reproduce this now.
Thank you Luboš!
Comment 5 Commit Notification 2020-09-30 09:39:31 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6b709ad5d46dc33f29ec28183cea40cf9e77e2af

fix DrawDeviceAlphaBitmap() with mirroring (tdf#136223)

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.