Bug 136247 - FILESAVE Background fill of data labels in chart is lost on saving
Summary: FILESAVE Background fill of data labels in chart is lost on saving
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Gülşah Köse
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2020-08-28 22:39 UTC by Regina Henschel
Modified: 2020-09-21 10:14 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
File for reproducing the bug (18.53 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-08-28 22:39 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-08-28 22:39:33 UTC
Created attachment 164836 [details]
File for reproducing the bug

Open attached file. The data labels of the chart have a light blue background.
Save a copy of the file in xlsx and in ods (ODF 1.3 extended) format.
Open the saved files.
In both, xlsx and ods, the data labels are transparent. The background fill is lost on saving.
Comment 1 Regina Henschel 2020-08-28 23:56:51 UTC
When I compare the original file with the saved one, I see these errors:

The child element <a:solidFill> of element <c:spPr> in <c:dLbls> is missing.

The child elements of element <c:dLbls> have a wrong order. According schema of OOXML (Appendix B.5.1, line 248) it should be <c:numFmt>, <c:spPr>, <c:txPr>, ...
Actuall written by LO is: <c:numFmt>, <c:txPr>, <c:spPr>, ...

<a:srgbClr> in <a:solidFill> in <a:ln> has val="FF00". It should be val="00FF00".
Comment 2 Xisco Faulí 2020-09-07 09:57:14 UTC
The import part was implemented in

author	Gülşah Köse <gulsah.kose@collabora.com>	2020-05-04 11:48:51 +0300
committer	Gülşah Köse <gulsah.kose@collabora.com>	2020-05-04 21:04:39 +0200
commit 603df08a1e0211099ce2cf258cfe64a74ed6ded9 (patch)
tree 135c13a729ff18260f7bdb71346d1d5c920f1ab7
parent e7f3731b8d3e930f85e7df0c0e55bbb1aaea191b (diff)
tdf#131175 Import data label solid fill and color.
Change-Id: I8a3ef6e60d4f2a13310bb9a8fc4eb873df3f9b4f

@Gülşah Köse, I thought you might be interested in this issue
Comment 3 Gülşah Köse 2020-09-18 11:37:09 UTC
Hi Regina, I couldn't reproduce the ods export part. Background is still light blue when saved as ods (1.3) Can you check it again?
Comment 4 Regina Henschel 2020-09-18 12:28:44 UTC
Yes ODF is OK for 1.3 extended, my fault. [I'm currently working on getting it for ODF 1.3 strict too, see https://gerrit.libreoffice.org/c/core/+/102381]
Comment 5 Gülşah Köse 2020-09-18 12:51:50 UTC
Ok, thank you.
Patches on the way:
https://gerrit.libreoffice.org/c/core/+/102999
https://gerrit.libreoffice.org/c/core/+/103005
Comment 6 Commit Notification 2020-09-18 16:56:28 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a11bb74d4f464e9639ddb5b8d87dc4770663fea8

tdf#136247 OOXML export data label background color.

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-09-21 07:33:37 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/de59062d95605e5c91d687e3441399ffb05ff2dc

tdf#136247 Change element order of data labels

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.