Description: Crash deleting a table Steps to Reproduce: 1. open the attached file 2. CTRL+A 3. CTRL+X 4. CTRL+V 5. Place cursor in table & press delete table button 6. CTRL+V 7. Place cursor in table & press delete table button -> Crash Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 165466 [details] Example file
@Noel Me speculating.. this might have something to do with the speed-up deleting large tables. It appears they UndoManager is involved.. Of course, feel free to ignore until confirmed and bibisected etc.
Confirmed and bibisected. f210da25d39e16738319e163de4132fa5d63aae7 is the first bad commit commit f210da25d39e16738319e163de4132fa5d63aae7 Author: Jenkins Build User <tdf@pollux.tdf> Date: Thu Sep 10 23:42:22 2020 +0200 source da5c289a9cae5d914937f235694fd5b0cb92547f source da5c289a9cae5d914937f235694fd5b0cb92547f instdir/program/libsvllo.so | Bin 1585152 -> 1585152 bytes instdir/program/libswlo.so | Bin 22179864 -> 22179864 bytes instdir/program/setuprc | 2 +- instdir/program/versionrc | 2 +- 4 files changed, 2 insertions(+), 2 deletions(-) Exactly, it's coming from "speed up deleting large cross page table" https://git.libreoffice.org/core/+/da5c289a9cae5d914937f235694fd5b0cb92547f Noel, you are already on CC of this bug.
(In reply to BogdanB from comment #3) > Confirmed and bibisected. > Exactly, it's coming from "speed up deleting large cross page table" > https://git.libreoffice.org/core/+/da5c289a9cae5d914937f235694fd5b0cb92547f > > Noel, you are already on CC of this bug. I do confirm the issue was introduced by the mentioned commit
I have no idea how to fix this, feel free to revert the optimisation commit
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0b3ff97d7d5a1e8471e494f4141165364203c192 tdf#136728: Revert "tdf#136238 speed up deleting large cross page table" It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.1.0.0.alpha0+ Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/3d6c7523aea5c2820f26c33688b2c9a767affc6b tdf#136728: Revert "tdf#136238 speed up deleting large cross page table" It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1da5f05be97b2cf4fa59adff6a77bdb70927202b tdf#136728 : sw_uiwriter: Add unittest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3273170cf63b37f415b21f560e300847bfd2ecde Revert "tdf#136728 : sw_uiwriter: Add unittest" It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.