Created attachment 165700 [details] Page size menu is inconsistent The mouse hover on each item in the menu is not working, and font size of the text is really inconsistent with the global font size of the GUI. See attached image for more info.
LibreOffice Version: 7.0.1.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US =7.0.1-1 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.73.0 Qt Version: 5.15.0 Kernel Version: 5.4.64-1-MANJARO OS Type: 64-bit
Valid Version: 7.0.1.2 (x64) Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
Dear medmedin2014, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The problem is still persistent Version: 7.4.0.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US 7.4.0-3 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.25.5 KDE Frameworks Version: 5.97.0 Qt Version: 5.15.5 Kernel Version: 5.19.7-1-MANJARO (64-bit) Graphics Platform: X11
repro 24.2
The glade file is sw/uiconfig/swriter/ui/pagesizecontrol.ui The controlling code is in sw/source/uibase/sidebar/PageSizeControl.cxx It is the only thing that uses a The sidebar is defined in svx/source/sidebar/tools/ValueSetWithTextControl.cxx It hardcodes Size aSize(250, 300); The font scales to fit inside of this box. Make the box bigger, and the font gets bigger. Obviously, due to different languages taking up more or less space than others, we can't just size this nicely for English text. This all looks pretty automatic to me. My "suggested" font size is 12pt, but of course it just gets scaled to fit inside the height of the rectangle. (The width scales to fit the length of the text (growing it if necessary) while the height seems to be the determiner of the font size. We are ValueSet::InsertItem a generic ValueSet of meType VALUESETITEM_USERDRAW, so SetOptimalSize() doesn't calculate any size (only Text and Image does that). Since we have two text strings, we can't ValueSet::InsertItem VALUESETITEM_IMAGE_AND_TEXT. So probably the only thing to do is to extend ValueSetWithTextControl to SetOptimalHeight.
(In reply to Justin L from comment #6) > So probably the only thing to do is to extend ValueSetWithTextControl to > SetOptimalHeight. In https://gerrit.libreoffice.org/c/core/+/154286, Maxim suggested re-writing the entire control to look more like "Columns" or "Margins". The big downside to that seems to be that the current page size won't be shown/selected.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1876feb8a8805b2f80537e2828c152ccbdf67fe2 tdf#136905 NBB: let ValueSetWithTextControl set optimal height It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6256d5fe2e7cb1bb002d5fe59527d3a3fbf6963f tdf#136905 NBB: use label font in ValueSetWithTextControl It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72986a5e505f8b62b30aa890c136e07cef3f9a2b tdf#159865 tdf#136905 NBB: font looked too small in page size choices It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7c3cdc88337959ddbb9799c4cee57901e94719f3 tdf#159865 Revert "tdf#136905 NBB: let ValueSetWithTextControl set optimal" It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/759c9ea8e66b5fc1a362cf914055ac498fbbd80a tdf#159865 Revert "tdf#136905 NBB: let ValueSetWithTextControl set optimal" It will be available in 24.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
bug 159865 showed that for different people, the size ends up being different. So all the work done here was reverted.