Description: Search term not highlighted after re-opening search dialog Steps to Reproduce: 1. open attachment 165739 [details] 2. CTRL+F & search for "Vestibulum" 3. CTRL+F search for "Vestibulum" 4. Press ESC 5. Press ESC Vestibulum in search field but not highlighted Actual Results: Vestibulum not highlighted (so not overwritteN-0 Expected Results: Should be overwritten Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: abcc4eb907661e07ad850ccce7eb06f129da4286 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL
Was not able to duplicate in version 7.1.0.0.alpha0+ (x64)
The problem is not document specific, the problem is the ESC key doesn't close the search box (like before), instead the word you are searched is loses the highlight. Steps to Reproduce: 1. Open Writer 2. Type something 2. Press CTRL+F and search for the word you typed (press enter) 3. Press ESC Actual results: The word loses the highlight. Expected Results: The word highlight should remain and the search box should close. Reproduced in: Version: 7.1.0.0.alpha0+ (x64) Build ID: 0f99330f33868594ad253656805918115823f59d CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL @Telesto: Can you confirm this?
1. Open Writer 2. Type something 3. Press CTRL+F and search for the word you typed (press enter) 4. Press ESC The word highlight should remain and the search box should close. -> Yes, I confirm this. However, my initial report was actually about step 5: 5. Press CTRL+F again -> Focus on search bar, but present search term not highlighted (so it can be overwritten)
(In reply to Telesto from comment #3) > 1. Open Writer > 2. Type something > 3. Press CTRL+F and search for the word you typed (press enter) > 4. Press ESC > > The word highlight should remain and the search box should close. > > -> Yes, I confirm this. > > However, my initial report was actually about step 5: > 5. Press CTRL+F again -> Focus on search bar, but present search term not > highlighted (so it can be overwritten) Looks like this is 2 different bugs, with and without step 5. With step 5 reproduced in: Version: 7.1.0.0.alpha0+ (x64) Build ID: 0f99330f33868594ad253656805918115823f59d CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL (windows only, can't reproduce in linux):
Bibisected using bibisect-win64-7.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a3a6ff25f5749207dbfae3d22ec5f2a3c8623d9a author: Caolán McNamara <caolanm@redhat.com> committer: Caolán McNamara <caolanm@redhat.com> summary: block gen's focus in/out callbacks from grab_focus like gtk's Adding CC: Caolán McNamara
(In reply to Attila Baraksó (NISZ) from comment #5) > Bibisected using bibisect-win64-7.1 to: > URL: > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=a3a6ff25f5749207dbfae3d22ec5f2a3c8623d9a > author: Caolán McNamara <caolanm@redhat.com> > committer: Caolán McNamara <caolanm@redhat.com> > summary: block gen's focus in/out callbacks from grab_focus like gtk's > > Adding CC: Caolán McNamara To be clear: this is about step 1-4? And step 5 needs a different report?
(In reply to Telesto from comment #6) > (In reply to Attila Baraksó (NISZ) from comment #5) > > Bibisected using bibisect-win64-7.1 to: > > URL: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > > ?id=a3a6ff25f5749207dbfae3d22ec5f2a3c8623d9a > > author: Caolán McNamara <caolanm@redhat.com> > > committer: Caolán McNamara <caolanm@redhat.com> > > summary: block gen's focus in/out callbacks from grab_focus like gtk's > > > > Adding CC: Caolán McNamara > > To be clear: this is about step 1-4? And step 5 needs a different report? Nope, this is your report with step 5. For the other I'll writing a bug report soon. For the record: Steps to Reproduce: 1. Open Writer 2. Type something 2. Press CTRL+F and search for the text you typed (press enter) 3. Press ESC (not absolutely necessary) 4. Press CRTL+F again Actual results: Notice that the text in the search box loses highlighting. Expected Results: The text in the search box should be highlighted. Version: 7.1.0.0.alpha0+ (x64) Build ID: 0f99330f33868594ad253656805918115823f59d CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a8c218a52a639b0e7f689dea878a0421702628e0 tdf#136941 call focus in handler explicitly It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.1.0.0.alpha0+ (x64) Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL @Caolán: Thanks for fixing this issue!
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d3b889b6d47e243e5bd93753e91f0ed030723a29 tdf#136941: sw: Add UItest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.