Bug 137005 - Skia: Crash when drawing shape in Calc
Summary: Skia: Crash when drawing shape in Calc
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Skia
  Show dependency treegraph
 
Reported: 2020-09-24 14:56 UTC by Regina Henschel
Modified: 2020-09-27 14:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Call Stack VS2019 (2.71 KB, text/plain)
2020-09-24 15:00 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-09-24 14:56:00 UTC
I have made a developer build of current master. I start Calc, then open the Drawing Toolbar and click on a shape icon to draw a shape ==> Crash.

It only crashes with Skia, both variants.

The crash is in the assert in
void SkiaSalBitmap::ResetCachedData()
{
    SkiaZone zone;
    // This should never be called to drop mImage if that's the only data we have.
    assert(mBuffer || !mImage);
    mImage.reset();
    mAlphaImage.reset();
}

From About, both cases crash:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 0d28097fadf44ed58cb5e3e9b9c04a65a7a33fd6
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 0d28097fadf44ed58cb5e3e9b9c04a65a7a33fd6
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 1 Regina Henschel 2020-09-24 15:00:20 UTC
Created attachment 165818 [details]
Call Stack VS2019
Comment 2 Roman Kuznetsov 2020-09-24 19:15:22 UTC
no repro in

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52a49f9e480ca03e231cfda82640a928393131c9
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Windows 10 only problem?
Comment 3 Telesto 2020-09-24 21:21:57 UTC
No repro either
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52a49f9e480ca03e231cfda82640a928393131c9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

However 'crash' is actually an assert crash (so likely a debug build required)
Comment 4 Luboš Luňák 2020-09-25 07:51:39 UTC
https://gerrit.libreoffice.org/c/core/+/103304
Comment 5 Regina Henschel 2020-09-27 14:01:10 UTC
Fix works. Tested in Version: 7.1.0.0.alpha0+ (x64)
Build ID: 5cb62b13ca8fec43fffe3f2000f61c1be7c5616c
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

and tested with Skia/Vulkan in same version.