Bug 137546 - Child Textbox uses the same alignment as the parent shape
Summary: Child Textbox uses the same alignment as the parent shape
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: bibisected, bisected
Depends on:
Blocks: Shape-Textbox
  Show dependency treegraph
 
Reported: 2020-10-16 21:43 UTC by Xisco Faulí
Modified: 2020-12-30 10:36 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (10.44 KB, application/vnd.oasis.opendocument.text)
2020-10-16 21:43 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-10-16 21:43:54 UTC
Created attachment 166445 [details]
sample file

Steps to reproduce:
1. Open attached document
2. Change shape alignment to right

-> The textbox also gets a right alignment within the shape. it was centered before changing the alignment

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: e897fdc46b07f211c4c96de103cfa494b645035a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-10-16 21:45:48 UTC
The issue started to happen after https://git.libreoffice.org/core/commit/06fd06597796d9e92117602245f3968c93707708, before that, the textbox didn't follow the shape at all
Comment 2 Dieter 2020-11-02 11:39:44 UTC
I confirm it with

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 3 Commit Notification 2020-11-24 10:32:51 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3347d71b23595919e167bd49932675e77cbbdbbb

tdf#137546 sw: fix text position at textbox alignment

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-11-24 20:11:10 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/7c21121f7caa8667d86fc1946ef2a337c5b15da9

tdf#137546 sw: fix text position at textbox alignment

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 NISZ LibreOffice Team 2020-12-30 10:36:36 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 368c56144aab5794c39d5bc2082d9b3d6d7cebdb
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!