Description: Changing inserted image to standard orientation slowish Steps to Reproduce: 1. Download attachment 166816 [details] 2. Insert -> Image -> 3. This image is rotated. Would you like to rotate it into standard orientation? 4. Press YES -> wait Actual Results: Rotating is slow Expected Results: Fast Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 94e6e140491de31c0788c91af855a75a3bb12709 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Taking 15 seconds or so
Also in 6.1 Feature for rotation isn't present in 6.0
Hi Telesto, Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping
Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp
Found in Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 not in Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 [if you do rotate or not being irrelevant; at least for 4.1]
It takes long time in Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 and Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b63c5ade3554a42def4bce94f9fd67ea66528214 It's fast in Version: 4.1.0.0.alpha1+ Build ID: a2c9d4f8bbde97f175bae4df771273a61251f40
This seems to have begun at the below commit. Adding Cc: to Tomaž Vajngerl; Could you possibly take a look at this one? Thanks 1df7d956210d4a9111e6a88000c9ab2e955b57b4 is the first bad commit commit 1df7d956210d4a9111e6a88000c9ab2e955b57b4 Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Sep 5 19:27:56 2015 +0800 source-hash-698315531414b223b35d8507fdf2f56dbcf6bc4c commit 698315531414b223b35d8507fdf2f56dbcf6bc4c Author: Tomaž Vajngerl <quikee@gmail.com> AuthorDate: Sun Jul 28 15:52:14 2013 +0200 Commit: Tomaž Vajngerl <quikee@gmail.com> CommitDate: Sun Jul 28 16:06:44 2013 +0200 fdo#66006 Convert to PNG for JPEG that can't be losslessly rotated If a JPEG image has a width or height which is not a multiple of 16 (width/heigh % 16 != 0) then it can't be completelly lossleessly rotated (the last uncomplete MCUs can't be rotated) and the image is cropped on the lower size. To prevent this such JPEG images must be rotated to PNG to prevent loss. Afterwards image can still be compressed with "Compress Graphic Dialog". Probably not a bug, but a feature - converting to PNG takes some time.
Created attachment 175471 [details] Example file (In reply to raal from comment #9) > Probably not a bug, but a feature - converting to PNG takes some time. Well, the commit might do the proper thing, but still fishy. 1) Attached the same image (unrotated). Compressing the image with 7.3 takes 6-7 seconds (without reducing image resolution). So it's not the compression as such taking 15 seconds. Rotation shouldn't be that expensive. Note: compressing in 4.2 was slow in general. So maybe some optimization been done for the regular case, but not this one? 1) 4.2 ask for rotation; 7.3 simply does (no clue why the dialog had to go). Lack of feedback.. Especially if it takes a longer time.
@Noel Quite a corner case, but perf isn't great under specific circumstances.
This functionality was added when we didn't have a working image rotation in Writer yet, so all we could do is try to rotate the image itself. Now we could just simply apply the rotation property in this case.
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a6c9519b5f92eab604a8884aa6db4e8f1ac616b3 tdf#137848 Speed up inserting rotated image It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I confirm this to be fixed Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a8ec21adf255b70bb6eeb0a1717190df303d8b26 CPU threads: 4; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded However the problem does still exist in a different scenario. When inserting an image by drag and drop, instead of Insert -> Image