Description: Format menu Hotkey i is assigned twice, to Image and Line. Two ways to avoid this: Lin_e Ima_ge Hotkey a is assigned twice; to avoid this: Pa_ragraph Steps to Reproduce: 1.open Draw Format menu 2.Hit ‘i’, get ‘Image’; hit ‘i’ again, to jump to ‘Line’ 3. Actual Results: get ‘Insert image’ dialogue instead of ‘Line’ Expected Results: hit ‘i’ twice should jump to ‘Line’ Reproducible: Always User Profile Reset: No Additional Info: solution: change Lin_e or Ima_ge
Reproduce with 7.0.2, taking. Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); 界面: zh-CN Calc: threaded (In reply to TorrAB from comment #0) > Hotkey a is assigned twice; to avoid this: > Pa_ragraph This won't work because Alt+R is current used by Region.
Created attachment 167285 [details] Screenshot of Draw's Format menu for master/7.1 Just checked out master/7.1, there are actually three pairs of double-used hotkeys in Draw's Format menu, "Text" and "Text..." (the naming probably should be more distinctive as well) both use Alt+X. (In reply to Ming Hua from comment #1) > (In reply to TorrAB from comment #0) > > Hotkey a is assigned twice; to avoid this: > > Pa_ragraph > > This won't work because Alt+R is current used by Region. Should be R for A_rea. Was just guessing from the Chinese translation and guessed wrong.
(In reply to Ming Hua from comment #2) > Should be R for A_rea. Was just guessing from the Chinese translation and > guessed wrong. OK. Try Para_graph. As to ‘Text’ and ‘Text…’, the first one needs no hotkey since it is first menu item, can be chosen by Enter; ‘x’ will jump to ‘Te_xt…’.
(In reply to TorrAB from comment #3) > (In reply to Ming Hua from comment #2) > > > Should be R for A_rea. Was just guessing from the Chinese translation and > > guessed wrong. > > OK. Try Para_graph. ... which would then prevent us from using G for Ima_ge. After some careful investigation, I'm inclined to keep P_aragraph and change T_able instead. > As to ‘Text’ and ‘Text…’, the first one needs no hotkey since it is first > menu item, can be chosen by Enter; ‘x’ will jump to ‘Te_xt…’. These labels are not just used for Draw's Format menu, the first "Text" is used for all of Write/Calc/Impress/Draw. Changing them is not a trivial thing. Also don't assume everyone uses the same workflow as you do (Alt+O to expand the Format menu, then Enter for the first "Text") when it comes to hotkeys. I personally would be very annoyed if someone removed the hotkey of the first sub-menu item just because Enter key can be used instead.
(In reply to Ming Hua from comment #4) > (In reply to TorrAB from comment #3) > > (In reply to Ming Hua from comment #2) > > OK. Try Para_graph. > ... which would then prevent us from using G for Ima_ge. ** Ima_ge was one option (to remove the ambiguity of ‘i’); the other is to keep _Image and use Lin_e > > Also don't assume everyone uses the same workflow as you do (Alt+O to expand > the Format menu, then Enter for the first "Text") when it comes to hotkeys. > I personally would be very annoyed if someone removed the hotkey of the > first sub-menu item just because Enter key can be used instead. **Why would you be annoyed? The first item in a menu is first, and highlighted, because it's presumed to be the most used; the user, without even reading what character is underlined, just hits ‘Enter’ to activate it. The hotkeys provide quick access to the OTHER items; the first, default item needs no hotkey.
(In reply to TorrAB from comment #5) > (In reply to Ming Hua from comment #4) > > > > Also don't assume everyone uses the same workflow as you do (Alt+O to expand > > the Format menu, then Enter for the first "Text") when it comes to hotkeys. > > I personally would be very annoyed if someone removed the hotkey of the > > first sub-menu item just because Enter key can be used instead. > > **Why would you be annoyed? The first item in a menu is first, and > highlighted, because it's presumed to be the most used; the user, without > even reading what character is underlined, just hits ‘Enter’ to activate it. > The hotkeys provide quick access to the OTHER items; the first, default item > needs no hotkey. Because I mainly use mouse for menu navigation. When I use Alt+<key> hotkeys, I almost exclusively use it as a fast way to access to a command that I know well and use a lot. Not unsimilar to the shortcuts like Ctrl+X for Cut, and Ctrl+V for paste, etc. In other words, when I use hotkeys, I don't look at the menu items, and don't care if it's the first (default) item or not. If I want to use hotkey for strikethrough texts, for example, I'll just remember "it's in F~ormat > T~ext > Strikethro~ugh", and press Alt+O,E,U without looking at the menu. So in this case removing Alt+X for Text item, even if it's the first one, still affects my workflow a lot. Like I said, different users have different workflows. When making UI changes, one should aim to disrupt as few workflows as possible.
As it turns out, changing hotkeys in menus is much more complicated than changing hotkeys in dialogs. Take the "P~aragraph/T~able" conflict for example, the "Paragraph" menu item is used in many places in all modules [1], and undoubtful many, if not all of them will also use this "P~aragraph" label and Alt+A hotkey. While the "Table" menu item is used in less places, it is used in one of the most visible place -- Writer's first level menu (with File, Edit, etc.) and it definitely uses the same "T~able" label as Draw's Format > Table menu. Changing either of these would affect many other places in the whole UI. While the design blog post [2] mentions the possibility of using "ContextLabel" in addition to "Label" property to solve the "Table" issue, I don't feel comfortable tackling this without a LO build environment available to test and iterate. So un-assign myself and set back to NEW. Hopefully someone more competent will be interested in this problem and give it another try. 1. https://opengrok.libreoffice.org/search?project=core&full=%22menu%3Aid%3D.uno%3AParagraphDialog%22&defs=&refs=&path=&hist=&type=&xrd=&nn=1&si=full&si=full 2. https://design.blog.documentfoundation.org/2018/02/28/easyhacking-all-about-terminology/