Bug 138739 - FILEOPEN DOCX First empty paragraph does not get direct formatted character settings
Summary: FILEOPEN DOCX First empty paragraph does not get direct formatted character s...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Character
  Show dependency treegraph
 
Reported: 2020-12-08 13:25 UTC by NISZ LibreOffice Team
Modified: 2021-01-25 15:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the original document side by side in Word and Writer (170.17 KB, image/png)
2020-12-08 13:25 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-12-08 13:25:48 UTC
Created attachment 167940 [details]
Screenshot of the original document side by side in Word and Writer

attachment #166880 [details] starts with a few empty paragraphs, the first one having some direct formatted character settings: Font is Comic Sans, font size is 24 and language is welsh.
Upon opening in Writer these revert to the style defaults for the very first paragraph, but not for the second and third.

Steps to reproduce:
    1. Open attachment #166880 [details]
    2. Observe the first empty paragraphs font settings

Actual results:
TNR 12 pt, en-GB language.

Expected results:
Comic Sans, 24 pt, welsh language.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Additional Information: 

Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=056933bc55608d0ca061539ae124d7b9386cdb62 
author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	2020-10-15 16:45:15 +0200
committer	László Németh <nemeth@numbertext.org>	2020-10-28 19:09:50 +0100

tdf#137802 sw: fix crash on deleting last paragraph

Adding CC to: Attila Bakos
Comment 1 Xisco Faulí 2020-12-09 20:39:45 UTC
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 Commit Notification 2020-12-21 08:08:57 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/25ca25ee25278536c56a2ac4a63af91100ce4d2e

tdf#138739 sw: fix regression of first paragraph

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-12-21 15:40:28 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/714b8efc9c4143da31d435f7ccb2bf02704a1b5f

Revert "tdf#138739 sw: fix regression of first paragraph"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-01-08 12:20:29 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7957123a144bfe66a99aa0d30a47900b6b621a70

tdf#138739 sw: fix regression of first paragraph

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2021-01-11 16:33:42 UTC
Verified in

Version: 7.2.0.0.alpha0+
Build ID: 5adc93a9a9426ef79054751be2904896f787a8a2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Attila Bakos, thanks for fixing this issue!!
Comment 6 Commit Notification 2021-01-15 09:04:10 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1d1bd898e21bd56fff467b785d7c2c801064ed83

tdf#138739 sw: fix regression of first paragraph

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2021-01-25 15:08:43 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: threaded

Thanks!