Bug 138774 - FILEOPEN: DOCX: nested tables not loaded at import time
Summary: FILEOPEN: DOCX: nested tables not loaded at import time
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-12-09 12:48 UTC by Xisco Faulí
Modified: 2021-03-31 13:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
sample file (993.39 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-12-09 12:48 UTC, Xisco Faulí
Details
LO DOCX export of the (size-optimized) test document (31.02 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-12-12 10:46 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-12-09 12:48:31 UTC
Created attachment 168000 [details]
sample file

Steps to reproduce:
1. Open attached document

-> At first, the document has 13 pages instead of 21. Then, if you scroll down, it hangs for a while at page 11 and finally pages 13-21 are loaded. Scrolling up and down is still problematic and hangs

Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-12-09 12:50:15 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=45504ca72e0f081de9e7cc4f1faf553c7361694d

author	László Németh <nemeth@numbertext.org>	2020-07-01 18:14:39 +0200
committer	László Németh <nemeth@numbertext.org>	2020-07-02 22:15:30 +0200
commit 45504ca72e0f081de9e7cc4f1faf553c7361694d (patch)
tree 196e3465f5f86db32bddcdf6226a69c60c5c46dd
parent 2b6fe73ddcd845b5dde581e3802cb29d804f7876 (diff)
tdf#133735 DOCX: fix paragraph settings of nested tables

Bisected with: bibisect-linux64-7.1

Adding Cc: to László Németh
Comment 2 László Németh 2020-12-12 10:44:15 UTC
Xisco: It seems, this is a table layout freezing, my patch only made it visible. Reverting my patch hasn't solved the same problem for the DOCX export of the original test document, see the new attachment. Maybe it worth's to bibisect that, too (checking only the commits older than my bibisected commit.)
Comment 3 László Németh 2020-12-12 10:46:24 UTC
Created attachment 168093 [details]
LO DOCX export of the (size-optimized) test document

It freezes LO without the previously bibisected commit, too.
Comment 4 Xisco Faulí 2020-12-14 14:23:37 UTC
(In reply to László Németh from comment #2)
> Xisco: It seems, this is a table layout freezing, my patch only made it
> visible. Reverting my patch hasn't solved the same problem for the DOCX
> export of the original test document, see the new attachment. Maybe it
> worth's to bibisect that, too (checking only the commits older than my
> bibisected commit.)

Hi László,
I fail to see what I have to bisect. Please, specify the sequence of steps
Comment 5 László Németh 2020-12-14 14:30:49 UTC
(In reply to Xisco Faulí from comment #4)
> Hi László,
> I fail to see what I have to bisect. Please, specify the sequence of steps

Hi Xisco,

I hope, bibisecting with the second test document before the commit 45504ca72e0f081de9e7cc4f1faf553c7361694d could give us a good code pointer. In fact, using recent HEAD instead of that commit must give the same (only with an extra 1-2 steps), sorry.
Comment 6 Xisco Faulí 2020-12-14 15:46:04 UTC
(In reply to László Németh from comment #5)
> (In reply to Xisco Faulí from comment #4)
> > Hi László,
> > I fail to see what I have to bisect. Please, specify the sequence of steps
> 
> Hi Xisco,
> 
> I hope, bibisecting with the second test document before the commit
> 45504ca72e0f081de9e7cc4f1faf553c7361694d could give us a good code pointer.
> In fact, using recent HEAD instead of that commit must give the same (only
> with an extra 1-2 steps), sorry.

The question is, what do I have to bisect ? If I open it in LibreOffice or MSO Word, from page 14 on, the document displays black boxes
Comment 7 László Németh 2020-12-14 16:27:34 UTC
(In reply to Xisco Faulí from comment #6)
> The question is, what do I have to bisect ? If I open it in LibreOffice or
> MSO Word, from page 14 on, the document displays black boxes

Ah, ok. The problem is still the freezing. I've only replaced the original images with those black ones for an unit test document, calling it as "size-optimized". I've made a half-revert of the bibisected commit with this kind of unit test document, but I've noticed, that it fixes only the first import. I've attached the export to this issue. It works well with older LO versions, but not with the master (with or without my bibisected commit), also the debug showed extensive looping control of the table layout code. There were a few fixes there, and one of them worsened the handling of this second attachment.
Comment 8 Xisco Faulí 2021-03-31 13:53:48 UTC
Dear László Németh,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.