Bug 138844 - UI: Label "type" & Image in the image properties dialog not really helpful (self-explaining)
Summary: UI: Label "type" & Image in the image properties dialog not really helpful (...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2020-12-12 09:36 UTC by Telesto
Modified: 2022-05-17 10:30 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-12 09:36:57 UTC
Description:
UI: Label "type" & Image  in the image properties dialog not really helpful (self-explaining) 

Steps to Reproduce:
1. open a file with image attachment 168083 [details]
2. Right click it -> Properties

Actual Results:
The tabs 'Type' and 'Image' not really helpful. Not sure how 'type' fit the content of the tab. And calling a tab 'Image' within an image dialog?. Which is partly about flipping/rotating..  

Expected Results:
No clear cut proposal. This is 'literally' an enhancement request (but without alternative proposition).

There is already a bug for duplicate settings (bug 132853). 

The image tab matches the "Position and size" section in the sidebar. So maybe position and size? Or Size en orientation? And moving "Link file name" in Image to "options" 

Type tab could be something like "anchoring & position". However some similarity between sidebar & tab structure maybe desired. 
---

Prefer first some getting some feedback if my report is resonating at all :P 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Regina Henschel 2020-12-12 12:57:01 UTC
This dialog is shared with other kind of frame objects, e.g. text frame, OLE-object, chart, Math object. Only the tabs "Image" and "Crop" are specific for Images.

I agree, that "Type" does not describe the tab content.
Comment 2 V Stuart Foote 2020-12-12 15:23:11 UTC
The 'Properties' dialog (by context menu, or Format -> Images menu) for Image frames is only present in Writer. Likewise for other Object Frames.

Images present on Impress or Draw canvas have no similar dialog.

Nor do images (and other objects) inserted onto calc sheets.

But since all modules do provide the block of image controls--'Crop', 'Edit with External Tool', 'Replace', 'Compress', 'Save'[1]--would an image/graphic specific 'Image Type' or 'Format' dialog make for more consistent UX cross module?

=-ref-=
[1] .uno:Crop, .uno:ExternalEdit, .uno:ChangePicture, .uno:CompressGraphic, .uno:SaveGrapic
Comment 3 Telesto 2020-12-12 19:05:30 UTC
(In reply to V Stuart Foote from comment #2)
In principle pro harmonization and sharing (although writer having some dedicated settings like wrap/anchoring)

But I think this not simply limited to GUI and also requiring harmonization of internals:

From: https://bugs.documentfoundation.org/show_bug.cgi?id=107843#c3

--
"Impress 8" produces an OLE. There crop is not needed, because it is done by the frame.

"Drawing Format" produces a shape. In Draw/Impress the command .uno:GrafAttrCrop contains the cropping. This command is not available in Writer. Therefore not the original image is inserted, but an image that only has the part, that remains after cropping. --> Feature request: Implement .uno:GrafAttrCrop for those shapes, that would be able to be cropped in Draw/Impress and then insert the shape in original size and crop it.

"GDI" contains an image wrapped into a vector format.
"Bitmap" contains an image directly.
Both "GDI" and "Bitmap" contain only the part, that remains after cropping. That has always been this way, so I would say it is more a feature request than a bug. I think, that the current behavior can be improved. The images can be inserted in original size and the same cropping as in Draw/Impress can then be applied automatically. For such images cropping is available in Writer as part of .uni:GraphicDialog. I don't know, whether the clipboard already contains the needed information.

Cropping is part of the style of family "Graphic" in file format. LibreOffice distinguishes between images as shapes and Writer-images, but nevertheless uses the same kind of style in file format, only naming one "gr" and the other "fr". Currently this distinction is necessary, because the capabilities of "Draw-Images" and "Writer-Images" are different.

The aim should be, to get rid of "Writer-Images". This issue belongs to this aim, regardless of naming it "bug" or "feature request".

---
Comment 4 Heiko Tietze 2020-12-15 09:14:07 UTC
Isn't just a renaming sufficient? Quick proposal: Type => Position and Size (as we do for shapes; the tab is also used for other objects), Image => Flip and Rotation (or we keep Image here).
Comment 5 Heiko Tietze 2021-01-07 09:27:40 UTC
We discussed the proposal in the design meeting.

Renaming "Type" to "Position and Size" was accepted but "Image" could be just "Rotation" (without Flip). Chart and formula objects also use "Type" for position and size information, while shapes or text boxes have "Position and Size" in the same tab. And shapes use "Rotation" (but have no flip option in this tab).

Code pointer:

sw/uiconfig/swriter/ui/picturedialog.ui

<object class="GtkLabel" id="type">
  <property name="label" translatable="yes" context="picturedialog|type">Type</property>

<object class="GtkLabel" id="picture">
<property name="label" translatable="yes" context="picturedialog|picture">Image</property>
Comment 6 sdc.blanco 2022-05-13 15:51:46 UTC
Why is/was the tab called "Type"?  

Maybe add the word "Properties" to the dialog title, so that the window would be named  "Image Properties"?
Comment 7 sdc.blanco 2022-05-17 10:30:27 UTC
(In reply to sdc.blanco from comment #6)
> Maybe add the word "Properties" to the dialog title, so that the window
> would be named  "Image Properties"?
No further input.  Here is patch -- without changing dialog title.
Have also made this change for the Frame dialog -- and will do the same for the Object dialog (because they have the same tab).

https://gerrit.libreoffice.org/c/core/+/134189