Bug 139409 - Remove Data provider code
Summary: Remove Data provider code
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Data-Provider
  Show dependency treegraph
 
Reported: 2021-01-04 16:40 UTC by Xisco Faulí
Modified: 2022-04-04 11:53 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-01-04 16:40:52 UTC
The data provider was improved in https://cgit.freedesktop.org/libreoffice/core/commit/?id=6250b856defa4d49469cb455c1eef53de02f623d.
Later the menu entry was removed in https://cgit.freedesktop.org/libreoffice/core/commit/?id=24939a5b43b9fe889c3aace027c668666ff61987

The menu entry should be visible if experimental option is enabled
Comment 1 Julien Nabet 2021-01-04 18:02:21 UTC
I think there was only Markus on it and he left LO development or almost considering https://cgit.freedesktop.org/libreoffice/core/log/?qt=author&q=Mohrhard

So what's the purpose here?
IMHO it should be removed instead of letting it rot in experimental and get some bugtrackers which will never be fixed.

Unless you know someone who will work on it?
Comment 2 Heiko Tietze 2021-01-05 09:54:27 UTC
Not finished functions should be experimental. But I wonder if we should add it back to the menu bar. Btw, the Tabbed and Tabbed Compact NBs show the commands. Should be removed, IMHO.

Code pointer: 

officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu

<node oor:name=".uno:DataProvider" oor:op="replace">
<node oor:name=".uno:DataProviderRefresh" oor:op="replace">

<prop oor:name="IsExperimental" oor:type="xs:boolean">
  <value>true</value>
</prop>

and

sc/uiconfig/scalc/ui/notebookbar_compact.ui
sc/uiconfig/scalc/ui/notebookbar.ui

<property name="action_name">.uno:DataProvider</property>
Comment 3 Julien Nabet 2021-01-05 11:33:31 UTC
(In reply to Heiko Tietze from comment #2)
> Not finished functions should be experimental. But I wonder if we should add
> it back to the menu bar. Btw, the Tabbed and Tabbed Compact NBs show the
> commands. Should be removed, IMHO.

See my previous comment.
Do you know someone who will work on Data provider? (of course, I don't mean the UI part which is an easyhack but all the rest)
I mean if nobody takes a look, it can stay experimental for years and just bring extra maintenance.
Comment 4 Heiko Tietze 2021-01-05 12:54:47 UTC
(In reply to Julien Nabet from comment #3)
> I mean if nobody takes a look, it can stay experimental for years and just
> bring extra maintenance.

Wouldn't be the only one that is forgotten ;-). 

But I'll bring up your removal request at the ESC (or you join yourself, it's not a closed group).
Comment 5 Julien Nabet 2021-01-05 18:17:47 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to Julien Nabet from comment #3)
> > I mean if nobody takes a look, it can stay experimental for years and just
> > bring extra maintenance.
> 
> Wouldn't be the only one that is forgotten ;-). 
Yep and they should be removed too if still experimental after several years :-)
> 
> But I'll bring up your removal request at the ESC (or you join yourself,
> it's not a closed group).
+1 for the request. About joining ESC, it's simpler for me to communicate by writing. No constraint of time, I can re read, ... + I expect the result (about the same as request to remove completely Thunderbird AB part which is now broken)
:-)
Comment 6 andreas_k 2021-01-05 20:29:21 UTC
is it only uno:DataProvider or also uno:DataProviderRefresh which will be experimental?
Comment 7 Heiko Tietze 2021-01-14 15:20:52 UTC
ESC approved removing the code. Shouldn't be too difficult to restore if someone wants  to restart the effort.
Comment 8 Julien Nabet 2021-01-16 09:05:08 UTC
(In reply to Heiko Tietze from comment #7)
> ESC approved removing the code. Shouldn't be too difficult to restore if
> someone wants  to restart the effort.

So let's change the title accordingly.
Comment 9 Julien Nabet 2021-01-16 09:09:13 UTC
Is still an easyhack? So nobody should take it except LO beginners?
If yes but no beginner take it, how many times should we wait before anybody can take it?
Last question, are we agree we can close all data provider related bugtrackers? (I haven't checked yet if there were and/or how many there were).
Comment 10 Heiko Tietze 2021-01-18 12:32:42 UTC
(In reply to Julien Nabet from comment #9)
> Is still an easyhack? So nobody should take it except LO beginners?

Please do it, you are the best in these tasks.
Comment 11 Aron Budea 2021-03-25 01:23:53 UTC
For the record, Data Provider is crashing since the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=9bba5f418d4900ba20503dd1d310b3ff68bb14df

On the other hand, someone in #libreoffice-calc was interested about the following GSoC idea recently:
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Implement_interface_for_external_data_source_import_into_Calc
Comment 12 Aron Budea 2021-03-25 01:51:39 UTC
At the same time, as a more urgent action, could someone remove the .uno:DataProvider and .uno:DataProviderRefresh items from the following Notebookbar UI files?

- sc/uiconfig/scalc/ui/notebookbar.ui
- sc/uiconfig/scalc/ui/notebookbar_compact.ui
Comment 13 Tushar Kumar Rai 2021-03-30 13:32:06 UTC
IMHO there is no need to remove the code of data provider.

The transformations and import part is working properly.There are problems in UI like browse option is not there,preview of imported data not getting loaded and many more.
The changes in UI needs to be done and adding more data providers and transformations which can be easily implemented.

I had a chat with Markus we concluded data providers can be brought into production once work on interface is done.

I am working on this for many days and going to take it as a part of my GSoC project.

Thanks.
Comment 14 Roman Kuznetsov 2021-06-18 12:24:53 UTC
So, should we close it as WONTFIX or better will be to wait the end of GSoC 2021?
Comment 15 Heiko Tietze 2021-06-18 13:56:47 UTC
Let's close