Bug 148352 - Provide access to the Data Provider in the UI
Summary: Provide access to the Data Provider in the UI
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Data-Provider
  Show dependency treegraph
 
Reported: 2022-04-04 09:20 UTC by Heiko Tietze
Modified: 2023-04-14 08:57 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2022-04-04 09:20:09 UTC
The command .uno:DataProvider and .uno:DataProviderRefresh are available for customization but yet not made available by default. I suggest to add an entry for "Data Provider" under Tools.
Comment 1 Xisco Faulí 2022-04-04 09:54:37 UTC
I guess we just have to revert

https://cgit.freedesktop.org/libreoffice/core/commit/?id=24939a5b43b9fe889c3aace027c668666ff61987

author	Markus Mohrhard <markus.mohrhard@googlemail.com>	2019-12-20 02:56:20 +0800
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2019-12-20 19:38:53 +0100
commit 24939a5b43b9fe889c3aace027c668666ff61987 (patch)
tree b6f37c2f8e109b9934de2120a17a4687bc0c9455
parent 9f749e97854009697d4263960c966313d3dd19d2 (diff)
the data provider feature is not ready for production
Comment 2 V Stuart Foote 2022-04-04 11:53:40 UTC
See the comment in see also bug 139409, should the Data Provider really be prominent if the ESC already said bin it as in cmnt #7? Otherwise experimental at best.
Comment 3 V Stuart Foote 2022-04-04 12:06:20 UTC
But, looks like it did get some more attention from Tushar with Markus' help, but was not finished up.

Heiko, "Seems Markus is busy. Let's submit and see if something breaks.", really?

OK, but wrap it as Experimental, please...
Comment 4 Heiko Tietze 2022-04-04 13:23:29 UTC
Don't have a strong opinion. Was just looking for the function today for bug 141380, and having it available for customization but not in the UI was surprising. We can also keep the ticket as reminder.
Comment 5 Stéphane Guillou (stragu) 2023-04-05 11:26:57 UTC
I vote for keeping it in experimental as a priority, given its current unpolished state ("Okay" button, no "Help" button... and that's just the surface aspect, I haven't tested the feature much).

OK to have it in UI once Experimental Features is on.
Comment 6 Julien Nabet 2023-04-13 16:36:54 UTC
So 2 years after my comment https://bugs.documentfoundation.org/show_bug.cgi?id=139409#c1 and more than 3 years Markus removed it from UI, how much extra time without any action on this part to considerate we can remove it?
Comment 7 Heiko Tietze 2023-04-14 08:49:08 UTC
(In reply to Julien Nabet from comment #6)
> how much extra time without any action on this part to considerate we can remove it?

Don't remove this awesome feature!
Comment 8 Julien Nabet 2023-04-14 08:57:26 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Julien Nabet from comment #6)
> > how much extra time without any action on this part to considerate we can remove it?
> 
> Don't remove this awesome feature!

I won't remove it but having this unused with UI since several years is just bloating the code and a burden (for example when there's some useful string refactoring).
I just wonder if lots of people know about the existence of this feature and use the 2 UNO commands you quoted.
If it's such an awesome feature, just wonder too why nobody is interested in fixing the UI after several years.
Finally why, after as you indicated ESC had approved the removal (https://bugs.documentfoundation.org/show_bug.cgi?id=139409#c7), we just don't apply the decision?
Don't forget that even after a removal, the code can be retrieved in git if someone wants to fix the UI pbs.