Bug 139486 - FORMS: Height of fields couldn't be changed by key directly
Summary: FORMS: Height of fields couldn't be changed by key directly
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.1 target:7.0.5
Keywords: bibisected, bisected, regression
: 139881 (view as bug list)
Depends on:
Blocks: Form-Controls
  Show dependency treegraph
 
Reported: 2021-01-07 20:43 UTC by Robert Großkopf
Modified: 2021-02-24 21:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2021-01-07 20:43:32 UTC
Open a Writer document.
Go to Form → Text Box.
Draw a text box.
Right mouse click on the box → Control Properties.
Go to the field for "Height" and change it by typing a new value in the combo field. Don't use the the possibility to change it by mouse.
Switch to the field for "Width". 
The new value will be shown but nothing changed for the box. Close control properties to change the new value.
Reopen control properties. Nothing has been saved.

Go 2 times to "Height", switch the value by typing something inside and move the cursor to "Width".
Now the height of the text box will be changed.

This buggy behavior appears with LO 7.0.4.1 and also LO 7.1.0.1 on OpenSUSE 15.2 64bit rpm Linux with vcl:kf5
Comment 1 Robert Großkopf 2021-01-07 20:46:20 UTC
Forgotten: This bug doesn't appear with LO 6.4.7.2 on the same machine. So it's a regression.
Comment 2 Dieter 2021-01-22 17:57:27 UTC
I confirm it with

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 9f9798f07f0b56ae474f31ded671cc8da598d244
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

but not with

Version: 6.1.6.3 (x64)
Build-ID: 5896ab1714085361c45cf540f76f60673dd96a72
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: CL
Comment 3 Justin L 2021-01-25 08:41:50 UTC
I could NOT reproduce in Ubuntu 20.04 with master or with bibisect-linux-64-7.0.
1.) insert form - text box and draw a decent sized box
2.) in control properties - height - I used the mouse to select the size and typed 0.5 instead. Then I either shift-tabbed, or clicked into the width control.

Result: I saw the textbox reduce in size on the canvas, even before pressing OK. 


However, I COULD reproduce it with SAL_USE_VCLPLUGIN=gen instdir/program/soffice

author	Caolán McNamara on 2019-12-09 13:28:35 +0100
LO 7.0 commit 1efeb17837c22499f00299c033ae59ba3910f7d7
    weld Property Browser

I noticed that if I also change the width, then the height change takes effect, but the width change doesn't.
Comment 4 Commit Notification 2021-01-25 16:22:04 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/46e525c36e62c7cb365f1a1f34373e726cfb49b7

tdf#139486 also listen to the Entry to determine if the SpinButton was changed

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2021-01-25 16:23:09 UTC
fixed in master, backport to 7-1 and 7-0 in gerrit
Comment 6 Commit Notification 2021-01-26 09:51:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/5ccf4f22c98553fc6530b38f235e31f168fa7fef

tdf#139486 also listen to the Entry to determine if the SpinButton was changed

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-01-26 09:51:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/d3e8ce1aef43cb5910429791fb00b3be7667f99e

tdf#139486 also listen to the Entry to determine if the SpinButton was changed

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Dieter 2021-02-09 07:38:01 UTC
Verified with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 396c2ad2daad6fe6a11703d0ae1593929834afe2
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

Caolán, thanks for fixing it!
Comment 9 Xisco Faulí 2021-02-23 09:37:24 UTC
*** Bug 139881 has been marked as a duplicate of this bug. ***
Comment 10 Commit Notification 2021-02-24 21:08:26 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bfcbccbf0c2798e6a36f43b72060289a9c0ca73f

tdf#139486: sw: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.