Bug 139658 - FILEOPEN: some (multi component) chart labels are incomplete
Summary: FILEOPEN: some (multi component) chart labels are incomplete
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, filter:ooxml, regression
Depends on:
Blocks: OOXML-Chart
  Show dependency treegraph
 
Reported: 2021-01-15 23:52 UTC by Gerald Pfeifer
Modified: 2021-06-14 08:42 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample chart (embedded in PPTX) (1.64 MB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-01-15 23:52 UTC, Gerald Pfeifer
Details
Visual comparison Office 365 vs LibreOffice 7.2, issues are marked (515.89 KB, image/png)
2021-01-15 23:53 UTC, Gerald Pfeifer
Details
The data table of the chart in PP 2019 and LO 7.2 nightly (141.02 KB, image/png)
2021-03-08 08:07 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2021-01-15 23:52:17 UTC
Created attachment 168925 [details]
Sample chart (embedded in PPTX)

Open the sample document and notice how the three pies chart elements on
the left side miss the first part of their labels: 

  "Linux", Red Hat, Scientific

The other labels appear complete.
Comment 1 Gerald Pfeifer 2021-01-15 23:53:53 UTC
Created attachment 168926 [details]
Visual comparison Office 365 vs LibreOffice 7.2, issues are marked
Comment 2 Gerald Pfeifer 2021-01-15 23:56:05 UTC
Version: 7.2.0.0.alpha0+
Build ID: 82cb5a3bb27bb70c97b3d04b9de97a3ff67231c5
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-12_20:54:16
Calc: threaded
Comment 3 Aron Budea 2021-03-07 02:57:56 UTC
Confirmed using LO 7.2.0.0.alpha0+ (94283af977246c70dbed4452d197b003d8bb14b9), 4.4.0.3 / Ubuntu.

Strictly looking at the text of the labels, this is a regression from the following commit, bibisected using repo bibisect-44max.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6c4e21a234f12e1310ba06f9859e08b424acf8bf
author		Kohei Yoshida <kohei.yoshida@collabora.com>	2014-07-02 09:53:54 -0400
committer	Kohei Yoshida <kohei.yoshida@collabora.com>	2014-07-02 20:56:31 -0400

bnc#812796: Correctly handle static value array for OOXML charts.
Comment 4 NISZ LibreOffice Team 2021-03-08 08:07:35 UTC
Created attachment 170331 [details]
The data table of the chart in PP 2019 and LO 7.2 nightly

Looks like the data table is imported incorrectly. The quotation marks of the "Linux" entry confuse the hell out of the importer.

Also: removing the quotation marks locally makes the chart appear just fine.

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 72841008bf422dfd8553240b3a78f0474d03523c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL
Comment 5 Commit Notification 2021-06-10 13:05:44 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c9f071ff49bace0809d3a55d4d4b76a26d933f9c

tdf#139658 OOXML: fix broken chart import at labels with quotes

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gerald Pfeifer 2021-06-14 08:42:48 UTC
Verified with

Version: 7.2.0.0.alpha1+ / LibreOffice Communit
Build ID: bb54d6d8241a06a6772052b77b67d6a4f686426c
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-11_20:14:38

Thank you, Tünde!