Bug 139808 - FILEOPEN PPTX Text with Z-rotation disappears from shape
Summary: FILEOPEN PPTX Text with Z-rotation disappears from shape
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, implementationError
Depends on: 146876
Blocks: PPTX-Shapes PPTX-Texteffect
  Show dependency treegraph
Reported: 2021-01-21 10:20 UTC by NISZ LibreOffice Team
Modified: 2023-10-16 07:30 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-01-21 10:20:50 UTC
Open bug #128206 ‘s attachment #155077 [details] in LO 7.1 and 7.2 master.
In 7.1 the rotated text is visible, as on attachment #169073 [details] but in 7.2 it disappears as on attachment #169074 [details]

Steps to reproduce:
    1. Open attachment #155077 [details] in 7.2 master

Actual results:
No rotated text visible on the left side shape.

Expected results:
Text should be visible.

LibreOffice details:
Version: (x64) / LibreOffice Community
Build ID: 6ee7a3b2c0565c2871d32d704cb2899445b9f88d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Additional Information: 

Bibisected using bibisect-win64-7.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=65e2ef43f186164729e1cc071b805bc1a7125cfe 
author	Miklos Vajna <vmiklos@collabora.com>	2021-01-06 10:23:44 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	2021-01-06 12:23:59 +0100

tdf#134288 svx: fix rendering of text on a zero-width shape

Adding CC to:  Miklos Vajna
Comment 1 Roman Kuznetsov 2021-01-22 14:16:15 UTC
confirm in

Version: (x64)
Build ID: 94f6765d6ecc3145fa2d266231124003cf953118
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded
Comment 2 Timur 2021-08-09 09:50:22 UTC
Repro 7.3+.
Comment 3 Justin L 2022-01-24 12:10:53 UTC
comment 0's commit was also backported to
A further complication in current master is bug 146876 which has broken the rotation of the shape itself.
Comment 4 Justin L 2022-02-01 13:38:04 UTC
This seems to be related to (adjusted to match the current code)
+ if (!bVerticalWriting && aAnchorRange.getWidth() == 0)
Comment 5 Miklos Vajna 2022-02-08 07:24:13 UTC
Before it would be lost in the sea of abandoned patches, https://gerrit.libreoffice.org/c/core/+/129424 fixes this problem in practice, it just needs investigation if it's the correct fix + cover it with a test.
Comment 6 Miklos Vajna 2023-10-16 07:30:27 UTC
The timeline I see:

- d0119ff7f2c68aa05286bd303128f3a69c6bbd6a (improve tools::Rectangle->basegfx::B2?Rectangle conversion, 2019-05-06): before this, nothing was visible, so this "started to work"
- 65e2ef43f186164729e1cc071b805bc1a7125cfe (tdf#134288 svx: fix rendering of text on a zero-width shape, 2021-01-06): the previous commit had a problem, so I had to tweak the behavior there

So this never really worked in a clean way, I think. Adjusting keywords accordingly.