Bug 140078 - Change Undo/Redo action label for chaining/unchaining frame from "text frame" to be just "frame"
Summary: Change Undo/Redo action label for chaining/unchaining frame from "text frame"...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.2.0
Keywords: topicUI
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2021-02-02 06:35 UTC by Rizal Muttaqin
Modified: 2021-02-04 09:54 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Link and Unlink text frame action label (9.23 KB, image/png)
2021-02-02 06:35 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2021-02-02 06:35:45 UTC
Created attachment 169376 [details]
Link and Unlink text frame action label

tdf#128227 provides an agreement to change "text frame" to be "frame". But some UIs are still using old "text frame". For example the action box in undo and redo dropdown button after chaining and unchaining frame elements.

Step to reproduce

1. Create a frame (e.g. Insert > Frame > Frame Interactively)
2. Create another frame (repeat first step)
3. Select the first frame, a frame toolbar should be appear in standard UI or Object tab in Tabbed UI
4. Click Link Frames, and select/click second frame
5. Click Undo drop down button, the last action show "Link text frame"
6. Reselect the first frame
7. Click Unlink Frames
8. Click Undo drop down button, the last action show "Unlink text frame"

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 15f2367cd910135f95d413515f5c28d88bfc685f
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-02-01_04:38:42
Calc: threaded

As a side note, why does "Link Frames" and "Unlink Frames" use plural object "Frames" instead just "Link Frame"/"Unlink Frame" as I can not select multiple frames at onces.
Comment 1 Commit Notification 2021-02-02 09:41:05 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9db40ef453eaa3e78ef852a35732e0d16e89b326

tdf#140078 change Text Frame string to Frame in Undo/Redo action label

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Rizal Muttaqin 2021-02-04 09:54:11 UTC
Fixed in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 947277146e4c1ff7544371095fcc6bd5842b2d98
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-02-02_19:17:41
Calc: threaded