Bug 140088 - No border around comboboxes with latest Breeze upstream changes (kf5)
Summary: No border around comboboxes with latest Breeze upstream changes (kf5)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2021-02-02 11:01 UTC by Michael Weghorn
Modified: 2021-09-06 07:20 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the issue (83.49 KB, image/png)
2021-02-02 11:01 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2021-02-02 11:01:43 UTC
Created attachment 169387 [details]
Screenshot showing the issue

original report here: https://bugs.kde.org/show_bug.cgi?id=432395

Steps to reproduce:
0. use KDE Plasma with Breeze style selected, and a Breeze version that includes commit https://invent.kde.org/plasma/breeze/-/commit/2f351fe101d6a706b618b4f9518581006f50b242 (e.g. build from git master branch)
1. start LO Calc
2. take a look at the comboboxes

Result: There is no (more) border around the comboboxes

Expected result: There should be a border.

Further information:

* In https://bugs.kde.org/show_bug.cgi?id=432395#c1, Fabian Vogt wrote:
"The LO issue can be explained by LO not taking frame margins into account (confirmed by adding 10px, but LO looked the same), so this might be fixed by https://github.com/LibreOffice/core/commit/771f1411c588a02ed276febc9a479323bf4232cd. I'm using 7.0.3.1 here, not sure whether that commit is included. Adding Michael Weghorn for info."

However, this issue is not yet fixed by that commit (and the others for tdf#138010). Possibly, a similar solution can be implemented for the comobox case, though - presumably related: 'Qt5Graphics_Controls::drawNativeControl', case 'else if (type == ControlType::Combobox)'

* The screenshot shows how this looks with Breeze 4:5.20.5-2 from Debian testing (OK, left side) and Breeze built from master branch as of commit 471839bc758c991dbee30205cb080f4ba5bab5a9) (NOK, right-hand side).

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 21312572497e43317faa2f115a2a5449a97f1b44
CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: kf5
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2021-02-02 11:02:48 UTC
Setting to NEW, since originally reported on https://bugs.kde.org/show_bug.cgi?id=432395

Needs further investigation, but looks like a LO issue.
Comment 2 Michael Weghorn 2021-09-06 07:20:37 UTC
This no longer happens with current Breeze master branch where the corresponding commit has been reverted for now since it was causing problems elsewhere, too:
https://invent.kde.org/plasma/breeze/-/commit/f9758726eeff08212778ea04c1fc284989ef2e82

-> closing as WORKSFORME for now

Please feel free to leave a comment here or create a new bug report in case this should become relevant again (e.g. in case another change with a similar effect should make it to newer Breeze versions).
Some WIP MRs seem to be e.g. at [1] and [2], but I haven't taken any closer look.

[1] https://invent.kde.org/plasma/breeze/-/merge_requests/63
[2] https://invent.kde.org/plasma/breeze/-/merge_requests/115