Bug 140969 - UI: All selected items in canvas should be highlighted in navigator
Summary: UI: All selected items in canvas should be highlighted in navigator
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2021-03-12 08:42 UTC by Telesto
Modified: 2023-03-29 22:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
demo of selected shapes on canvas selected in navigator (365.58 KB, application/x-matroska)
2021-06-03 06:03 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-03-12 08:42:01 UTC
Description:
All selected items in canvas should be highlighted in navigator

Steps to Reproduce:
1. Open attachment 170036 [details]
2. Sidebar -> Navigator deck
2. Select one of the shapes of the figure
3. Drag a area around the others (so others) -> Notice single entry selected in sidebar. In draw you can drag around it and select (with even nothing selected in the sidebar)




Actual Results:
Single entry selected

Expected Results:
All elements selected


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc3b64dcbfb0a49c0be65bd8d73ed4e6d3828a21
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-03-12 08:45:00 UTC
FWIW, as far I'm concerned this should also work visa versa. Select multiple items  navigator to highlight those object in document (and even consider grouping)

Maybe this should be limited to objects on single page, though. But this is only an idea, implementation probably more complex
Comment 2 Heiko Tietze 2021-03-15 10:07:39 UTC
Sounds reasonable. Jim, what do you think?
Comment 3 Jim Raykowski 2021-04-18 23:44:39 UTC
@Heiko, sorry for the delayed response. I'll try to look into this.
Comment 4 Jim Raykowski 2021-04-26 02:02:18 UTC
While poking around I found that using space bar sort of already works to select multiple Drawing objects in the document from the Navigator.

https://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/content.cxx?r=c0aa577d#3611
Comment 5 Jim Raykowski 2021-04-28 14:32:07 UTC
comment 4 was for similar report in bug 129610.

Here is a patch that selects in Navigator Drawing objects content navigation view all drawing objects selected in the document:

https://gerrit.libreoffice.org/c/core/+/114811
Comment 6 Commit Notification 2021-05-05 06:01:25 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b43ab86df783c7816deb5810d89d52e2c3a93b5a

tdf#140969 Select in Navigator all document selected drawing objects

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 BogdanB 2021-06-02 13:17:00 UTC
I can NOT select more than one shape. If I select al the shapes, just one is selected.

I tested in Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded
Comment 8 Heiko Tietze 2021-06-02 14:10:03 UTC
(In reply to BogdanB from comment #7)
> I can NOT select more than one shape.

Confirming with 
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 6d1b5bfe5b0439c8f953c93e449a9c7fdaf2e443
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 9 Jim Raykowski 2021-06-03 06:03:37 UTC
Created attachment 172586 [details]
demo of selected shapes on canvas selected in navigator

(In reply to BogdanB from comment #7)
> I can NOT select more than one shape. If I select al the shapes, just one is
> selected.
> 
This only works in Drawing Objects content navigation view mode. Please see demo.
Comment 10 Heiko Tietze 2021-06-03 07:05:37 UTC
Any chance to always enable this? It's not really intuitive ;-)
Comment 11 BogdanB 2021-06-03 15:44:16 UTC
It's working after enabling Content Navigation View. But I had no ideea I need to click there.

Tested in Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: f49e5902a3737c02fabf5bec23243ccb126426c4
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded