Bug 141140 - GTK3: menubuttons toggled states not visually consistent throughout the toolbars
Summary: GTK3: menubuttons toggled states not visually consistent throughout the toolbars
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Notebookbar Notebookbar-Theming gtk3-themeing Button-Controls
  Show dependency treegraph
Reported: 2021-03-21 03:30 UTC by Jeff Fortin Tam
Modified: 2022-03-21 10:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

demonstration video (550.60 KB, video/mp4)
2021-03-21 03:30 UTC, Jeff Fortin Tam
Screencast with Gen (83.93 KB, image/gif)
2022-03-21 10:22 UTC, Heiko Tietze
Screencast with gtk3 (46.83 KB, image/gif)
2022-03-21 10:23 UTC, Heiko Tietze
Screencast with kf5 (66.93 KB, image/gif)
2022-03-21 10:23 UTC, Heiko Tietze

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2021-03-21 03:30:01 UTC
Created attachment 170600 [details]
demonstration video

In GTK (and various other toolkits), clicking on a menubutton will not only toggle the visibility of the associated menu or popover, but also set the button to be visually in a toggled "pressed" state.

However, throughout LibreOffice's toolbar variants, including the "Tabbed" toolbar and particularly the "Groupedbar compact" toolbar, I can see at least three different visual styles when clicking various menubuttons:

- Some do not show a pressed/toggled state at all (which looks very "wrong" :)
- Some show a visual style specific to Libreoffice, very "rectangular" & flat
- Some show a visual style that resembles GTK3's togglebuttons' toggled state

Ideally they should all be in the 3rd category.
The attached video demonstrates the various styles observed.
Comment 1 Heiko Tietze 2022-03-21 10:07:55 UTC
Kf5 shows a frame around the control which remains there when the menu expands. Gen has a very strong "lowered" border indicator for GtkButtons and a less obtrusive but still visible frame for menu/toolbar buttons that expand into floating widgets. 

Gtk3 shows the frame around menu/toolbar buttons but reverts the menu buttons.

Caolan, what do you think?

Some one-shot functions such as the chevron to show the hidden toolbar/notebookbar items reverts back to the original state. That's correct IMO.
Comment 2 Heiko Tietze 2022-03-21 10:22:46 UTC
Created attachment 179000 [details]
Screencast with Gen
Comment 3 Heiko Tietze 2022-03-21 10:23:07 UTC
Created attachment 179001 [details]
Screencast with gtk3
Comment 4 Heiko Tietze 2022-03-21 10:23:25 UTC
Created attachment 179002 [details]
Screencast with kf5
Comment 5 Caolán McNamara 2022-03-21 10:34:01 UTC
if this issue boils down to the notebookbar under gtk, then we are still not using real gtk widgets in the notebookbar, it's the remaining major thing that is "unwelded" and has all the theming issues associated with that.
Comment 6 Heiko Tietze 2022-03-21 10:47:49 UTC
Patch https://gerrit.libreoffice.org/c/core/+/105265 was abandoned due to inactivity.