Created attachment 170600 [details]
In GTK (and various other toolkits), clicking on a menubutton will not only toggle the visibility of the associated menu or popover, but also set the button to be visually in a toggled "pressed" state.
However, throughout LibreOffice's toolbar variants, including the "Tabbed" toolbar and particularly the "Groupedbar compact" toolbar, I can see at least three different visual styles when clicking various menubuttons:
- Some do not show a pressed/toggled state at all (which looks very "wrong" :)
- Some show a visual style specific to Libreoffice, very "rectangular" & flat
- Some show a visual style that resembles GTK3's togglebuttons' toggled state
Ideally they should all be in the 3rd category.
The attached video demonstrates the various styles observed.
Kf5 shows a frame around the control which remains there when the menu expands. Gen has a very strong "lowered" border indicator for GtkButtons and a less obtrusive but still visible frame for menu/toolbar buttons that expand into floating widgets.
Gtk3 shows the frame around menu/toolbar buttons but reverts the menu buttons.
Caolan, what do you think?
Some one-shot functions such as the chevron to show the hidden toolbar/notebookbar items reverts back to the original state. That's correct IMO.
Created attachment 179000 [details]
Screencast with Gen
Created attachment 179001 [details]
Screencast with gtk3
Created attachment 179002 [details]
Screencast with kf5
if this issue boils down to the notebookbar under gtk, then we are still not using real gtk widgets in the notebookbar, it's the remaining major thing that is "unwelded" and has all the theming issues associated with that.
Patch https://gerrit.libreoffice.org/c/core/+/105265 was abandoned due to inactivity.