Bug 141268 - FILEOPEN: ODP Incorrect Skew in shapes
Summary: FILEOPEN: ODP Incorrect Skew in shapes
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://docs.oasis-open.org/office/Op...
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Reported: 2021-03-26 15:22 UTC by Xisco Faulí
Modified: 2021-04-06 14:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

sample file (23.40 KB, application/vnd.oasis.opendocument.presentation)
2021-03-26 15:22 UTC, Xisco Faulí
Comparison 7.1 vs 7.2 (71.28 KB, image/png)
2021-03-26 15:22 UTC, Xisco Faulí

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-03-26 15:22:16 UTC
Created attachment 170765 [details]
sample file

Steps to reproduce:
1. Open attached document

-> The shapes in the pyramid are drawn incorrectly. See comparison image

Reproduced in

Version: / LibreOffice Community
Build ID: 3e4eb070787d4d44b3bdc95046e5b231dbbef42b
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2021-03-26 15:22:37 UTC
Created attachment 170766 [details]
Comparison 7.1 vs 7.2
Comment 2 Xisco Faulí 2021-03-26 15:23:55 UTC
Regression introduced by:


author	Regina Henschel <rb.henschel@t-online.de>	2021-03-20 20:05:19 +0100
committer	Regina Henschel <rb.henschel@t-online.de>	2021-03-22 19:08:27 +0100
commit 2bf8c1e0e211601a70b6b28fdb92f636c7969513 (patch)
tree 8e0eb7ab30abe29dacd96c5fe26e400796bee7c5
parent fe0543c8186ece4a1c315e6b14acabcb7d6f4d16 (diff)
tdf#141127 Use ODF default values for draw:extrusion-skew

Bisected with: bibisect-linux64-7.2

Adding Cc: to Regina Henschel
Comment 3 Regina Henschel 2021-03-26 18:18:51 UTC
We have a principle problem here. After my patch, LibreOffice shows, what is written in the file. You see the same directions as in LO7.2 if you open the file in PowerPoint.

The relevant part of the spec is section 19.167 in part 3.
The draw:extrusion-skew attribute specifies the skew amount and skew angle of an extrusion. Skew settings are only applied if the dr3d:projection 19.102 attribute on the same element has the value parallel.
The attribute value is a white space separated number and angle. The first value defines the skew amount in percent, the second value defines the skew angle.
The default value for this attribute is 50 45.

The part "The default value ..." means, that this value is used, if the attribute does not exist in file.

The question is, why LO7.1 has not written 'draw:extrusion-shew="50 -135"' and does it happen in LO7.2, that 'draw:extrusion-shew="50 -135"' is not written? Do you have a scenario?

[To repair the file go into the group, mark all shapes, select a different direction, unselect, select again and mark the intended direction "South-West", save. The value is written to file then.]
Comment 4 Regina Henschel 2021-03-28 13:08:52 UTC
If you toggle a custom shape to extrusion mode, the default setting is a skew angle of -135 ("South West"). If you then save the document without touching the Directions floater, LibreOffice does not write the skew angle to file. Unfortunately this is an old error, so that there exists a lot of files, which have the attribute missing. I have written bug 141301 about the missing attribute.

So my suggestion here is: Revert my patch from 7.1 and from 7.2.
Next step would be, to change implementation in 7.1 and 7.2 so, that the skew angle -135 is written to file. I don't know yet how to do it.
Then, after some time, add the patch to e.g. 7.3.

And is there a way to reliable detect, that a document was written by OpenOffice or LibreOffice, so that the missing skew angle could be set to -135 on opening in those cases?
Comment 5 Regina Henschel 2021-04-03 16:20:30 UTC
I have reverted the patch for 7.2., https://gerrit.libreoffice.org/c/core/+/113538.
Xisco: Will you revert it for 7.1 too? Or can I do it?
Comment 6 Xisco Faulí 2021-04-06 08:07:58 UTC
(In reply to Regina Henschel from comment #5)
> I have reverted the patch for 7.2.,
> https://gerrit.libreoffice.org/c/core/+/113538.
> Xisco: Will you revert it for 7.1 too? Or can I do it?

Done in https://gerrit.libreoffice.org/c/core/+/113636
Comment 7 Commit Notification 2021-04-06 14:24:11 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":


tdf#141268: svx_unit: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2021-04-06 14:24:37 UTC
I guess we can close this