Bug 142031 - Formula bar suggestion tooltips don't like accents
Summary: Formula bar suggestion tooltips don't like accents
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.3.0.4 release
Hardware: All All
: medium normal
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.5.0 target:7.4.2
Keywords: bibisected, bisected, needsDevEval, regression
Depends on:
Blocks: Calc-Formula-Bar
  Show dependency treegraph
 
Reported: 2021-05-01 17:54 UTC by TorrAB
Modified: 2022-09-09 08:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sheet with accented variables (8.15 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-05-16 12:38 UTC, TorrAB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2021-05-01 17:54:39 UTC
If a variable name has an accented character, it cannot be chosen from the tooltips when entering data. Example: variable ‘Crédit’; in a cell, enter ‘=cr’; tooltip appears ‘[CRITBINOM, Crédit …]’; add ‘é’: tooltip disappears; add ‘d’: new tooltip appears: ‘[DATE]…’, as if ‘cré’ did not exist. However, you can enter ‘Crédit’ —without tooltip help.
Comment 1 TorrAB 2021-05-16 12:38:44 UTC
Created attachment 172058 [details]
sheet with accented variables
Comment 2 TorrAB 2021-05-16 13:09:11 UTC
In Accents.ods, cell A1 is named ‘crédit’, cell B1 is named ‘pâte’.
Try to enter ‘=crédit’ in cell A2, get a tooltip after ‘=’, ‘c’ and ‘r’, but no tooltip after ‘é’ (You may need a French or USInternational keyboard for this.); then, ‘d’ gives tooltips beginning with ‘d’, as if ‘cré’ did not exist.
Try to enter ‘=pâte’ in cell B2; get a tooltip after ‘=’ and ‘p’, but no tooltip after ‘â’; then, ‘t’ gives tooltips beginning with ‘t’, as if ‘pâ’ did not exist.
Comment 3 Aron Budea 2021-05-17 05:04:20 UTC
Confirmed using LO 7.2.0.0.alpha0+ (54387d1d35cb79a30be208052831de74efd8b2f2), 5.2.0.4 / Ubuntu.

This was working differently before 5.2:
1. before 4.3.0.4 the tooltip is only showing the user-specified name (no functions), and the tooltip persists even if the user types accented characters,
2. between 4.3.0.4 and 5.2.0.4 only a single function name is shown in the suggestion.

First change in 4.3:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b0b7553241bb5150b12bbf7625b4b0b36970272
author		Winfried Donkers <winfrieddonkers@libreoffice.org>	2014-02-25 08:14:55 +0100
committer	Eike Rathke <erack@redhat.com>	2014-05-12 16:44:20 +0000

"fdo#75264 fix incorrect/missing function tips in Calc"

Second change in 5.2:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b2a82d9bb256516ac589350579b90f43b68bd452
author		Keigo Kawamura <2448848492@mail.ecc.u-tokyo.ac.jp>	2015-11-16 20:39:06 +0900
committer	Eike Rathke <erack@redhat.com>	2016-01-18 17:42:20 +0000

"tdf#95878 made more useful function suggestion system in formula editing"

This might be an easy-hack, Eike, could you confirm if you agree?
Comment 4 Commit Notification 2022-08-26 19:40:31 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e1a32c881a7230481ecc8659d587e3621213e10f

tdf#142031 - Collect all the characters for the formula suggestion auto input

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-09-06 13:30:36 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9a193c81f735771796a347cb4d545b8d277c0625

tdf#142031: sc: Add UItest

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-09-07 06:23:24 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/bbd08d1dcdbb2dd8c30f590b2a8b785b64d01564

tdf#142031 - Collect all the characters for the formula suggestion auto input

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-09-07 07:39:40 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/5f8b4b4023f32edf78ab1ba87e11dc063d85b48f

tdf#142031: sc: Add UItest

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Kevin Suo 2022-09-08 18:16:53 UTC
This is a great fix - now, finally, I can see the tooltip suggestion of my Named Range in Chinese characters when I am typing formula in a cell.

My I ask to backport this to 7.3 branch?
Comment 9 Eike Rathke 2022-09-09 08:44:55 UTC
No. This depends on other quite intrusive changes; also the next 7.3.7 release will be the last in the 7.3 chain, if anything went wrong there wouldn't be a chance to fix.